#bitfighter IRC Log

Index Search ←Prev date Next date→

IRC Log for 2026-04-22

Timestamps are in GMT/BST.

02:58:00BFLogBot Pull request #755 closed by eykamp | Title: Fix findPointerOfArg whitespace handling and add unit tests | https://github.com/bitfighter/bitfighter/pull/755
02:58:00BFLogBot Repo: bitfighter | Commit: fb799a67d1 | Author: eykamp | Message: Fix findPointerOfArg to robustly handle whitespace (#755) Modified findPointerOfArg in zap/stringUtils.cpp to correctly handle: 1. Leading whitespace at the beginning of the message. 2. Multiple consecutive whitespace characters between arguments. 3. Different types of whitespace using isspace(). The function now correctly skips leading whitespace for any requested argument index
02:58:01BFLogBot and returns a pointer to the first non-whitespace character of that argument. Added corresponding unit tests in bitfighter_test/TestStringUtils.cpp. I am an AI agent. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
05:47:28BFLogBot Repo: bitfighter | Commit: 63c08e7b43 | Author: eykamp | Message: Progress on vehicle desiner
06:54:18BFLogBot Repo: bitfighter | Commit: 4479df327d | Author: google-labs-jules[bot] | Message: Fix undefined behavior in function calls This commit fixes a bug where signed characters were being passed directly to functions like tolower(), toupper(), isalnum(), etc. According to the C standard, these functions expect an int representable as an unsigned char or EOF. Passing a signed char with the high bit set results in a negative value and
06:54:20BFLogBot undefined behavior. Modified files: - zap/stringUtils.cpp: cast to (unsigned char) in caseInsensitiveStringCompare - zap/UIMenuItems.cpp: cast to (unsigned char) in handleTextInput - zap/md5wrapper.cpp: cast to (unsigned char) in lcase - tnl/platform.cpp: cast to (unsigned char) in stricmp and strnicmp - master/authenticator.cpp: cast to (unsigned char) in isSqlSafe - bitfighter_test/TestFileLogging.cpp: cast to (unsigned char) in lineContainsTi
06:54:21BFLogBot mestamp - updater/src/TinyXml/tinyxml.h & tinyxmlparser.cpp: cast to (unsigned char) in various places Added unit tests in bitfighter_test/TestStringUtils.cpp to verify correct handling of non-ASCII characters in string comparisons. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
06:54:21BFLogBot Pull request #756 opened by eykamp | Title: Fix undefined behavior in function calls | https://github.com/bitfighter/bitfighter/pull/756
14:15:17BFLogBot Repo: bitfighter | Commit: 210dd8e482 | Author: google-labs-jules[bot] | Message: Standardize safe calls with Zap namespace wrappers This commit fixes a pervasive bug where signed characters were being passed directly to functions (tolower, toupper, isalpha, etc.), which is undefined behavior for characters with the high bit set. Changes: - Added safe inline wrappers in zap/stringUtils.h (Zap::toLower, Zap::isSpace, etc.) that
14:15:18BFLogBot handle the necessary (unsigned char) cast. - Replaced direct calls to functions with these safe wrappers across the codebase (zap/, tnl/, master/, bitfighter_test/, and TinyXml in updater/). - Added new unit tests in bitfighter_test/TestStringUtils.cpp to verify the wrappers and ensure correct handling of non-ASCII characters. - Cleaned up manual casts previously added to maintain code readability. I am an AI agent. Co-authored-by: ey
14:15:20BFLogBot kamp <1133323+eykamp@users.noreply.github.com>
14:22:56BFLogBot Repo: bitfighter | Commit: e48af40f1d | Author: Copilot | Message: Replace tinyxml with tinyxml2 in updater Agent-Logs-Url: https://github.com/bitfighter/bitfighter/sessions/d3b00ed0-7c78-4906-94a6-58e6cc64487b Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
14:38:36BFLogBot Repo: bitfighter | Commit: 33f7e6b801 | Author: google-labs-jules[bot] | Message: Standardize safe calls with wrappers and refined namespace usage This commit fixes undefined behavior caused by passing signed characters to functions (tolower, toupper, isalpha, etc.) when the high bit is set. Changes: - Introduced safe inline wrappers in zap/stringUtils.h (toLower, toUpper, isSpace, etc.) that handle mandatory (unsigned char) c
14:38:37BFLogBot asting. - Systematically updated the codebase to use these safe wrappers, removing redundant 'Zap::' qualifications where possible. - Fixed third-party TinyXml (updater/) using manual (unsigned char) casts to maintain its independence from the Zap namespace. - Added comprehensive unit tests in bitfighter_test/TestStringUtils.cpp to verify correct handling of non-ASCII characters. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.no
14:38:39BFLogBot reply.github.com>
16:35:01BFLogBot Repo: bitfighter | Commit: dcb81353eb | Author: google-labs-jules[bot] | Message: Standardize safe calls with TNL namespace wrappers This commit fixes undefined behavior caused by passing signed characters to functions (tolower, toupper, isalpha, etc.) when the high bit is set. Changes: - Introduced safe inline wrappers in tnl/tnlPlatform.h (TNL::toLower, TNL::isSpace, etc.) that handle mandatory (unsigned char) casting. - The
16:35:03BFLogBot se wrappers are available to the rest of the project via the TNL namespace. - Systematically updated the codebase (zap/, tnl/, master/, bitfighter_test/) to use these safe wrappers, relying on 'using namespace TNL' or unqualified calls where appropriate. - Preserved TinyXml's independence by ensuring it does not reference downstream code, as it is slated for a separate upgrade. - Added comprehensive unit tests in bitfighter_test/TestStringUtils.c
16:35:04BFLogBot pp to verify correct handling of non-ASCII characters. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
16:40:44BFLogBot Pull request #756 closed by eykamp | Title: Fix undefined behavior in function calls | https://github.com/bitfighter/bitfighter/pull/756
16:40:45BFLogBot Repo: bitfighter | Commit: 5dbc425e1a | Author: eykamp | Message: Fix undefined behavior in function calls (#756) * Fix undefined behavior in function calls This commit fixes a bug where signed characters were being passed directly to functions like tolower(), toupper(), isalnum(), etc. According to the C standard, these functions expect an int representable as an unsigned char or EOF. Passing a signed char with the h
16:40:47BFLogBot igh bit set results in a negative value and undefined behavior. Modified files: - zap/stringUtils.cpp: cast to (unsigned char) in caseInsensitiveStringCompare - zap/UIMenuItems.cpp: cast to (unsigned char) in handleTextInput - zap/md5wrapper.cpp: cast to (unsigned char) in lcase - tnl/platform.cpp: cast to (unsigned char) in stricmp and strnicmp - master/authenticator.cpp: cast to (unsigned char) in isSqlSafe - bitfighter_test/TestFileLogging.cp
16:40:48BFLogBot p: cast to (unsigned char) in lineContainsTimestamp - updater/src/TinyXml/tinyxml.h & tinyxmlparser.cpp: cast to (unsigned char) in various places Added unit tests in bitfighter_test/TestStringUtils.cpp to verify correct handling of non-ASCII characters in string comparisons. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> * Standardize safe calls with Zap namespace wrappers This commit fixes a per
16:40:50BFLogBot vasive bug where signed characters were being passed directly to functions (tolower, toupper, isalpha, etc.), which is undefined behavior for characters with the high bit set. Changes: - Added safe inline wrappers in zap/stringUtils.h (Zap::toLower, Zap::isSpace, etc.) that handle the necessary (unsigned char) cast. - Replaced direct calls to functions with these safe wrappers across the codebase (zap/, tnl/, master/, bitfighte
16:40:51BFLogBot r_test/, and TinyXml in updater/). - Added new unit tests in bitfighter_test/TestStringUtils.cpp to verify the wrappers and ensure correct handling of non-ASCII characters. - Cleaned up manual casts previously added to maintain code readability. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> * Standardize safe calls with wrappers and refined namespace usage This commit fixes undefined behavior caus
16:40:53BFLogBot ed by passing signed characters to functions (tolower, toupper, isalpha, etc.) when the high bit is set. Changes: - Introduced safe inline wrappers in zap/stringUtils.h (toLower, toUpper, isSpace, etc.) that handle mandatory (unsigned char) casting. - Systematically updated the codebase to use these safe wrappers, removing redundant 'Zap::' qualifications where possible. - Fixed third-party TinyXml (updater/) using manual (unsigned char
16:40:54BFLogBot ) casts to maintain its independence from the Zap namespace. - Added comprehensive unit tests in bitfighter_test/TestStringUtils.cpp to verify correct handling of non-ASCII characters. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> * Standardize safe calls with TNL namespace wrappers This commit fixes undefined behavior caused by passing signed characters to functions (tolower, toupper, is
16:40:56BFLogBot alpha, etc.) when the high bit is set. Changes: - Introduced safe inline wrappers in tnl/tnlPlatform.h (TNL::toLower, TNL::isSpace, etc.) that handle mandatory (unsigned char) casting. - These wrappers are available to the rest of the project via the TNL namespace. - Systematically updated the codebase (zap/, tnl/, master/, bitfighter_test/) to use these safe wrappers, relying on 'using namespace TNL' or unqualified calls where appropriate. - Pr
16:40:57BFLogBot eserved TinyXml's independence by ensuring it does not reference downstream code, as it is slated for a separate upgrade. - Added comprehensive unit tests in bitfighter_test/TestStringUtils.cpp to verify correct handling of non-ASCII characters. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-autho
16:40:59BFLogBot red-by: eykamp <1133323+eykamp@users.noreply.github.com>
17:36:26BFLogBot Repo: bitfighter | Commit: b3fb7de883 | Author: google-labs-jules[bot] | Message: Fix: Escape control characters in sanitizeForJson Identify and fix a bug where ASCII control characters (0-31) were being silently removed from strings by sanitizeForJson instead of being properly escaped. Changes: - Implement \uXXXX escaping for control characters in zap/stringUtils.cpp. - Use dSprintf for safe formatting. - Add comprehensive unit tests in bitfig
17:36:28BFLogBot hter_test/TestStringUtils.cpp covering all control characters (1-31) and ensuring existing short escapes (like \n, \r) are preserved. I am an AI agent assisting with this task. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
17:36:31BFLogBot Pull request #757 opened by eykamp | Title: Fix: Escape control characters in sanitizeForJson | https://github.com/bitfighter/bitfighter/pull/757
17:38:15BFLogBot Pull request #757 closed by eykamp | Title: Fix: Escape control characters in sanitizeForJson | https://github.com/bitfighter/bitfighter/pull/757
17:38:15BFLogBot Repo: bitfighter | Commit: 82a0b3cb4a | Author: eykamp | Message: Fix: Escape control characters in sanitizeForJson (#757) Identify and fix a bug where ASCII control characters (0-31) were being silently removed from strings by sanitizeForJson instead of being properly escaped. Changes: - Implement \uXXXX escaping for control characters in zap/stringUtils.cpp. - Use dSprintf for safe formatting. - Add comprehensive unit tests in bitfighter_test
17:38:17BFLogBot /TestStringUtils.cpp covering all control characters (1-31) and ensuring existing short escapes (like \n, \r) are preserved. I am an AI agent assisting with this task. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
17:39:47BFLogBot Repo: bitfighter | Commit: 509833fac5 | Author: eykamp | Message: Initialize string
17:41:44BFLogBot Repo: bitfighter | Commit: b32c6a700c | Author: eykamp | Message: Initialize output buffer in oglconsole.cpp Initialize output buffer to zero.
19:29:04BFLogBot Repo: bitfighter | Commit: e8e7ee7f4b | Author: Copilot | Message: Reduce avoidable S32/U32 casts in string rendering helpers Agent-Logs-Url: https://github.com/bitfighter/bitfighter/sessions/c9e0eff9-5006-42a2-95b7-d87128b19cb5 Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>

Index Search ←Prev date Next date→

These logs were automatically created by BFLogBot on irc.freenode.net.