Timestamps are in GMT/BST.
| 00:01:54 | raptor | here: this works: http://sam686.maxhushahn.com/upload/new_undo_system_working.diff |
| 00:02:06 | raptor | but now the select loadout zone after undo is worse |
| 00:03:31 | sam686 | maybe, the extents of zones may be wrong... |
| 00:03:38 | raptor | that' what i'm thinking... |
| 00:03:44 | sam686 | should make the renderer draw the extents... |
| 00:06:26 | raptor | EditorObject::renderInEditor looks liek a good place |
| 00:12:16 | raptor | ah ha! |
| 00:12:39 | sam686 | i used this: Rect r = getExtent(); UserInterface::drawRect(r.min.x, r.min.y, r.max.x, r.max.y, GL_LINE_LOOP); |
| 00:12:59 | sam686 | i was in EditorObject::renderInEditor |
| 00:14:33 | sam686 | looks like, extents don't properly work... |
| 00:14:59 | raptor | yeah, they show up when moving a vertex, but disappear when you do an undo |
| 00:16:13 | sam686 | in gridDB.cpp, in DatabaseObject::DatabaseObject(const DatabaseObject &t), try adding mExtent = t.mExtent; |
| 00:16:31 | raptor | ok |
| 00:17:27 | raptor | IT WORKS! |
| 00:17:29 | raptor | wow |
| 00:17:34 | raptor | is it working for you, too? |
| 00:18:31 | sam686 | it works for polygons, it looks like |
| 00:19:28 | sam686 | some items like ResourceItem, seems to set the extents extremely tiny when doing "move - undo - move" |
| 00:19:57 | raptor | yeah, their extents are just a point, it looks like |
| 00:20:03 | raptor | also flags |
| 00:21:11 | raptor | uh oh |
| 00:21:13 | raptor | still the bug |
| 00:21:57 | sam686 | probably, mRadius don't get copied like it should.. |
| 00:21:58 | raptor | that test level i put on the wiki, still has the exact same problem |
| 00:22:09 | sam686 | in item class |
| 00:22:55 | raptor | yeah, Core is a dot... |
| 00:24:32 | raptor | ok, i'm going home, i'll be back in a little bit... |
| 00:24:37 | sam686 | ok |
| 00:24:54 | raptor | so it looks like lots of objects have messed up extents and radius.. |
| 00:25:20 | | raptor Quit (Remote host closed the connection) |
| 00:48:08 | | raptor has joined |
| 00:48:08 | | ChanServ sets mode +o raptor |
| 00:48:16 | raptor | ok back |
| 00:58:25 | raptor | so the question: at what point are extents actually calculated? |
| 01:05:39 | | CrazyLinuxNerd Quit (Quit: Leaving) |
| 01:39:49 | sam686 | the Extents is calculated when moving or changing points in Polygon |
| 01:47:36 | sam686 | umm, i think all the point items is always zero size extents it seems, even without any such undo feature... |
| 01:47:53 | raptor | where do you see that? |
| 01:48:19 | raptor | i guess that's OK, though... |
| 01:48:20 | sam686 | the only time i see extent as not tiny dot is when loading a level |
| 01:54:38 | raptor | i don't think extents are the problem... the issue is still there with the polygon item with that test level i put in the wiki |
| 01:54:52 | sam686 | umm, i think this needs to change: Rect PointGeometry::calcExtents() {return Rect(mPos, 1);} (why 1?) |
| 02:13:47 | raptor | i have no idea |
| 02:27:14 | sam686 | ok, i may have pushed a change that fix mExtent, and fix tiny extents for all Item objects.. |
| 02:28:05 | sam686 | i was careful not to push your diff.. |
| 02:28:46 | | BFLogBot - Commit f35c54050536 | Author: sam8641 | Log: Fix mExtent not being copied, fix Item's extent too tiny by adding Item::calcExtents |
| 02:31:20 | raptor | isn't it better to have smaller extents for point objects so they're more likely to be in a certain grid bucket? |
| 02:32:18 | sam686 | i am not exactly sure, but there might be a big Item, like Asteroid |
| 02:32:26 | raptor | also Core |
| 02:32:31 | raptor | is a large point item |
| 02:32:58 | raptor | sorry, i will be off and on all night - i have guests over... |
| 02:33:04 | sam686 | extent too big don't matter much in editor anyway... |
| 02:33:31 | sam686 | but, bigger extents seems to make it easier to select those items |
| 02:53:34 | sam686 | g |
| 02:53:39 | raptor | searching seems to still work ok with Core |
| 02:53:40 | sam686 | oops, wrong chat.. |
| 02:53:57 | raptor | turrets still recognize the edgtes not to shoot.. |
| 02:54:00 | sam686 | i was playing some bitfighter 015, and i tried to chat in bitfighter.. |
| 02:58:41 | | LoneWolfy has joined |
| 02:59:02 | LoneWolfy | does anybody know coding club pass?!? |
| 02:59:07 | sam686 | Wone Wolf may have a problem with a password thing in "Coding club" |
| 02:59:13 | sam686 | not sure, i don't know.. |
| 02:59:30 | LoneWolfy | _k? |
| 03:00:37 | LoneWolfy | :| |
| 03:00:40 | LoneWolfy | UGH |
| 03:01:14 | sam686 | probably ask karamazovapy ..... |
| 03:01:25 | karamazovapy | ? |
| 03:01:47 | sam686 | its the password thing in "Coding club" |
| 03:01:55 | sam686 | Wone wold wants to know |
| 03:01:56 | karamazovapy | we're done with class, so I cleared it just now |
| 03:14:53 | LoneWolfy | But maybe you should keep it something like "Codin" or something |
| 03:15:05 | LoneWolfy | bai |
| 03:15:09 | | LoneWolfy Quit () |
| 06:05:42 | | raptor Quit (Remote host closed the connection) |
| 06:17:45 | | sam686 Quit (Ping timeout: 245 seconds) |
| 06:27:50 | | zoomber_mbp has joined |
| 07:39:50 | zoomber_mbp | oh hey zoomber |
| 07:39:57 | zoomber_mbp | i see your still logged in on my other computer |
| 07:49:59 | | Watusimoto has joined |
| 07:55:15 | | Watusimoto Quit (Ping timeout: 245 seconds) |
| 08:09:34 | | zoomber_mbp Quit (Quit: zoomber_mbp) |
| 08:10:18 | | Watusimoto has joined |
| 08:14:57 | | CrazyLinuxNerd has joined |
| 09:09:07 | Watusimoto | !bug |
| 09:09:07 | BFLogBot | To enter a bug, please make sure it is reproducible and then go to http://code.google.com/p/bitfighter/issues/list | Also, see current buglist for 016: http://bitfighter.org/wiki/index.php?title=Buglist_016 |
| 09:09:17 | | BFLogBot - Commit 3e62c80db738 | Author: watusim...@bitfighter.org | Log: Remove includes |
| 09:09:19 | | BFLogBot - Commit 1441d576f2bc | Author: watusim...@bitfighter.org | Log: Move WSM into database |
| 09:09:20 | | BFLogBot - Commit 0507e2878479 | Author: watusim...@bitfighter.org | Log: Merge |
| 09:09:22 | | BFLogBot - Commit e9a1f495b924 | Author: watusim...@bitfighter.org | Log: Change energy item symbol to match repair item symbol -- as per request by phantom |
| 09:09:23 | | BFLogBot - Commit fdf1363b86a4 | Author: watusim...@bitfighter.org | Log: Fix crash when exiting game |
| 09:09:25 | | BFLogBot - Commit ea4af9a12068 | Author: watusim...@bitfighter.org | Log: Whitespace |
| 09:09:26 | | BFLogBot - Commit 5ef6ebda5d33 | Author: watusim...@bitfighter.org | Log: Whitespace |
| 09:09:28 | | BFLogBot - Commit c094edab0d94 | Author: watusim...@bitfighter.org | Log: Whitespace |
| 09:09:29 | | BFLogBot - Commit aeda74060e7e | Author: watusim...@bitfighter.org | Log: Defensive assert |
| 09:09:31 | | BFLogBot - Commit f363409ae01e | Author: watusim...@bitfighter.org | Log: Merge |
| 09:09:32 | | BFLogBot - Commit fd10c088b5f0 | Author: watusim...@bitfighter.org | Log: Get a different database |
| 09:45:48 | | LordDVG has joined |
| 10:05:21 | | Watusimoto Quit (Ping timeout: 247 seconds) |
| 10:47:51 | | koda has joined |
| 10:48:10 | | koda Quit (Client Quit) |
| 12:50:14 | | Watusimoto has joined |
| 13:38:55 | | Watusimoto Quit (Ping timeout: 252 seconds) |
| 13:44:08 | | raptor has joined |
| 13:44:08 | | ChanServ sets mode +o raptor |
| 13:50:06 | | koda has joined |
| 13:54:45 | | raptor Quit (Remote host closed the connection) |
| 15:14:33 | | Watusimoto has joined |
| 15:48:13 | | raptor has joined |
| 15:48:13 | | ChanServ sets mode +o raptor |
| 15:48:17 | raptor | good day! |
| 15:49:34 | raptor | oooo Watusimoto checked in.. |
| 15:51:03 | raptor | must fix ocmpilng |
| 15:55:03 | | BFLogBot - Commit fdf86fea74f4 | Author: buckyballreaction | Log: Fix compiling |
| 17:10:51 | | raptor Quit (Ping timeout: 252 seconds) |
| 17:12:18 | | bobdaduck has joined |
| 17:12:32 | bobdaduck | yoyo |
| 17:25:05 | | Watusimoto Quit (Ping timeout: 240 seconds) |
| 17:41:13 | | LordDVG Quit (Quit: mjuza, better way for listening to music: sf.net/projects/mjuza/) |
| 17:43:43 | | LordDVG has joined |
| 18:04:15 | | koda Quit (Quit: koda) |
| 18:15:09 | | sam686 has joined |
| 18:15:09 | | ChanServ sets mode +v sam686 |
| 18:26:40 | | bobdaduck Quit (Quit: Page closed) |
| 18:38:56 | | raptor has joined |
| 18:38:56 | | ChanServ sets mode +o raptor |
| 18:39:16 | | raptor Quit (Remote host closed the connection) |
| 19:13:58 | | Watusimoto has joined |
| 19:34:50 | | LordDVG Quit (Ping timeout: 245 seconds) |
| 19:46:49 | | Watusimoto Quit (Ping timeout: 252 seconds) |
| 20:36:46 | | LordDVG has joined |
| 20:57:00 | | raptor has joined |
| 20:57:00 | | ChanServ sets mode +o raptor |
| 21:08:11 | | Watusimoto has joined |
| 21:08:20 | Watusimoto | hi |
| 21:08:23 | raptor | hi |
| 21:08:32 | Watusimoto | i am exhausted |
| 21:08:42 | Watusimoto | carrying 500lb boxes from ikea |
| 21:08:46 | raptor | ha! |
| 21:08:51 | raptor | we just got new couches... |
| 21:08:56 | raptor | from there |
| 21:09:04 | raptor | uh... in UT |
| 21:09:08 | Watusimoto | right |
| 21:09:12 | Watusimoto | I guessed |
| 21:10:08 | Watusimoto | am going to try to finishe what I started this morning, if i don;t fall asleep |
| 21:10:13 | raptor | ok |
| 21:10:16 | raptor | i'll cheer you on |
| 21:10:21 | Watusimoto | ha |
| 21:10:36 | raptor | so i redid the undo system and the bug still existed |
| 21:10:39 | raptor | the evil one |
| 21:10:47 | Watusimoto | evilist of bugs will be an easy fix, I think, if only I can find the right spot |
| 21:10:59 | Watusimoto | yes, I think the problem is with copying items |
| 21:11:05 | raptor | really? |
| 21:11:14 | Watusimoto | and both undos will suffer the same problem |
| 21:11:30 | Watusimoto | yes; I think the coordinates of point items are not being copied correctly |
| 21:11:43 | Watusimoto | maybe my emails weren't clear |
| 21:12:16 | raptor | i added: setActualPos(t.getActualPos()); |
| 21:12:26 | raptor | in the copy contructor of 'Item' |
| 21:12:34 | raptor | and it didn't make a lick of difference |
| 21:13:30 | raptor | which reminds me, i have to read up on copy constructors - i don't actually know what they functionally do |
| 21:14:58 | Watusimoto | this isn't going to work. I'm going to bed early, I'll work some more tomorrow. today was just draining |
| 21:15:06 | raptor | ok |
| 21:15:09 | raptor | good choice |
| 21:15:11 | raptor | oh |
| 21:15:19 | raptor | do we wan tthe new undo system? |
| 21:15:24 | Watusimoto | so.... later! I'm convinced with another hour or two we'll have that bug fixed |
| 21:15:39 | Watusimoto | how is the performance on a large level (ctf3?) |
| 21:15:54 | raptor | what specific action should i do? copy/paste the whole thing? |
| 21:16:03 | Watusimoto | doesn't matter |
| 21:16:10 | Watusimoto | the same undo gets run either way |
| 21:16:12 | raptor | ok |
| 21:16:14 | raptor | i'll test |
| 21:16:18 | raptor | and post results later |
| 21:16:59 | Watusimoto | ok. see if you can get a handle on the memory usage as well; try doing 30 or so actions, that will fill up 30 stages of undo, and compare the memory usage |
| 21:17:17 | raptor | what way would you use to compare memory usage? |
| 21:17:23 | Watusimoto | no idea |
| 21:17:28 | Watusimoto | actually |
| 21:17:30 | raptor | sounds good! |
| 21:18:00 | Watusimoto | I would probably look at windows program manager and see what's listed (or, rather, the sysinternals replacement I use). no idea if that is accurate |
| 21:18:12 | Watusimoto | maybe top, or ps on linux? |
| 21:18:18 | raptor | ther eis a ksysguard |
| 21:18:27 | raptor | a much nicer version of windows task manager... :) |
| 21:18:39 | Watusimoto | My thinking is either the difference will be apparent or it won't |
| 21:19:04 | raptor | ok |
| 21:19:11 | Watusimoto | yoour machine is so fast that I don;t know if you'll notice a performance difference |
| 21:19:19 | Watusimoto | even if there is one |
| 21:19:29 | raptor | i can profile... but i can check memory |
| 21:19:32 | Watusimoto | I suspect it will be more aparent on undoing than on saving an undo state |
| 21:19:58 | Watusimoto | undo on 016 shoudl be nearly instaneous |
| 21:20:20 | raptor | with which system?, the new griddatabase one? |
| 21:20:21 | Watusimoto | on 015a, and your method, all objects in that vector need to be added to the database |
| 21:20:26 | raptor | yes |
| 21:20:44 | Watusimoto | swapping grid databases is nearly instant |
| 21:20:49 | raptor | yes |
| 21:21:00 | raptor | but memory usage is larger, no? |
| 21:21:33 | Watusimoto | so maybe focus on memory; if memory is worse with the db switch, then maybe the 015a system is better? |
| 21:22:08 | raptor | i think speed is favorable nowadays |
| 21:22:21 | Watusimoto | if memory is not hugely different, and performacne is not hugely different, then let's just keep what we've got |
| 21:22:26 | raptor | ok |
| 21:22:28 | Watusimoto | the database method has a certain elegance |
| 21:23:13 | Watusimoto | so I guess I'm suggesting we do some measurements and make a decsion based on the results |
| 21:23:19 | raptor | ok |
| 21:23:21 | Watusimoto | you know, scientifically |
| 21:24:54 | raptor | i wonder if i can profile memory... |
| 21:25:00 | raptor | i'll run some trials |
| 21:25:02 | Watusimoto | maybe we could ask sam686 to see if he notices a performance difference on his machine |
| 21:25:07 | raptor | and detail my results |
| 21:25:12 | Watusimoto | if he doens't notice, no one will :-) |
| 21:25:16 | raptor | ha! |
| 21:25:41 | Watusimoto | ok, signing off |
| 21:25:55 | raptor | night |
| 21:50:35 | | BFLogBot - Commit 79026aeacc7b | Author: buckyballreaction | Log: Minor casting issue |
| 22:11:47 | | Watusimoto Quit (Ping timeout: 248 seconds) |
| 22:27:18 | raptor | 1. segfault when undoing in editor. used ctf3 and copy/pasted/undid the entire level: http://pastie.org/3227220 |
| 22:27:50 | raptor | also notice what happened to turrets/ffs and point items after the paste |
| 22:29:10 | raptor | it happens with both undo systems |
| 22:29:41 | raptor | be back ina little bit |
| 22:29:44 | | raptor Quit (Remote host closed the connection) |
| 22:51:59 | | LordDVG Quit (Remote host closed the connection) |
| 22:53:18 | | koda has joined |
| 23:22:27 | | raptor has joined |
| 23:22:27 | | ChanServ sets mode +o raptor |