Index Search ←Prev date Next date→
Timestamps are in GMT/BST.
| 15:02:19 | BFLogBot Repo: bitfighter | Commit: ae3b3c0272 | Author: google-labs-jules[bot] | Message: Fix 64-bit integer conversion in itos functions Previously, itos(U64) was using %u which truncated the value to 32 bits, and itos(S64) had an incorrectly declared buffer size and used %d. Both now use the correct 64-bit format specifiers and buffer sizes. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 15:02:23 | BFLogBot Pull request #681 opened by eykamp | Title: Fix 64-bit integer conversion in itos functions | https://github.com/bitfighter/bitfighter/pull/681 | |
| 15:15:23 | BFLogBot Repo: bitfighter | Commit: 015eb8d2fc | Author: google-labs-jules[bot] | Message: Add length checks to stripZeros to prevent out-of-bounds access stripZeros could access index -1 of the string if it became empty during zero stripping (e.g., when the input is "0"). Added checks to ensure the string is not empty before accessing its last character. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 15:21:55 | BFLogBot Repo: bitfighter | Commit: a2defaa20b | Author: google-labs-jules[bot] | Message: Fix 64-bit integer conversion in itos functions Previously, itos(U64) was using %u which truncated the value to 32 bits, and itos(S64) had an incorrectly declared buffer size and used %d. Both now use the correct 64-bit format specifiers and buffer sizes. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 15:42:03 | BFLogBot Pull request #681 closed by eykamp | Title: Fix 64-bit integer conversion in itos functions | https://github.com/bitfighter/bitfighter/pull/681 | |
| 15:42:03 | BFLogBot Repo: bitfighter | Commit: ae3b3c0272 | Author: google-labs-jules[bot] | Message: Fix 64-bit integer conversion in itos functions Previously, itos(U64) was using %u which truncated the value to 32 bits, and itos(S64) had an incorrectly declared buffer size and used %d. Both now use the correct 64-bit format specifiers and buffer sizes. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 15:42:05 | BFLogBot Repo: bitfighter | Commit: 015eb8d2fc | Author: google-labs-jules[bot] | Message: Add length checks to stripZeros to prevent out-of-bounds access stripZeros could access index -1 of the string if it became empty during zero stripping (e.g., when the input is "0"). Added checks to ensure the string is not empty before accessing its last character. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 15:42:06 | BFLogBot Repo: bitfighter | Commit: a2defaa20b | Author: google-labs-jules[bot] | Message: Fix 64-bit integer conversion in itos functions Previously, itos(U64) was using %u which truncated the value to 32 bits, and itos(S64) had an incorrectly declared buffer size and used %d. Both now use the correct 64-bit format specifiers and buffer sizes. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 15:42:08 | BFLogBot Repo: bitfighter | Commit: 1cebbabb28 | Author: eykamp | Message: Merge pull request #681 from bitfighter/fix-itos-64bit-8558908212478676849 Fix 64-bit integer conversion in itos functions | |
| 15:50:12 | BFLogBot Repo: bitfighter | Commit: b96ebc82ed | Author: google-labs-jules[bot] | Message: Fix extractExtension when no dot is present extractExtension would return the full path if no dot was present. It now correctly returns an empty string. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:15:05 | BFLogBot Repo: bitfighter | Commit: 13375efa23 | Author: google-labs-jules[bot] | Message: Fix extractExtension to return empty string if no dot found Previously it returned the full filename when no dot was present. This PR fixes that and adds a unit test. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:30:44 | BFLogBot Repo: bitfighter | Commit: 4f7616008c | Author: google-labs-jules[bot] | Message: Fix misleading indentation in bitfighter_test/main_test.cpp This commit fixes a misleading indentation in the checkResources function where a return statement was indented as if it were inside a loop, but was actually outside. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:30:51 | BFLogBot Pull request #682 opened by eykamp | Title: Fix misleading indentation in bitfighter_test/main_test.cpp | https://github.com/bitfighter/bitfighter/pull/682 | |
| 16:35:29 | BFLogBot Comment on issue #682 | User: eykamp | Comment: Since you've provided tests for isInteger, please add one testing for a negative int; the current code will return False ... | https://github.com/bitfighter/bitfighter/pull/682#issuecomment-4194842550 | |
| 16:35:55 | BFLogBot Comment on issue #682 | User: google-labs-jules[bot] | Comment: > Since you've provided tests for isInteger, please add one testing for a negative int; the current code will return Fal ... | https://github.com/bitfighter/bitfighter/pull/682#issuecomment-4194844881 | |
| 16:36:26 | BFLogBot Repo: bitfighter | Commit: e226763839 | Author: google-labs-jules[bot] | Message: Add test case for negative integer in isInteger As requested in the PR feedback, I've added a test case for negative integers. This verifies that isInteger returns false for strings containing a '-' sign, as it currently only accepts digit-only strings. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:41:00 | BFLogBot Pull request #682 closed by eykamp | Title: Fix misleading indentation in bitfighter_test/main_test.cpp | https://github.com/bitfighter/bitfighter/pull/682 | |
| 16:41:01 | BFLogBot Repo: bitfighter | Commit: 4f7616008c | Author: google-labs-jules[bot] | Message: Fix misleading indentation in bitfighter_test/main_test.cpp This commit fixes a misleading indentation in the checkResources function where a return statement was indented as if it were inside a loop, but was actually outside. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:41:02 | BFLogBot Repo: bitfighter | Commit: e226763839 | Author: google-labs-jules[bot] | Message: Add test case for negative integer in isInteger As requested in the PR feedback, I've added a test case for negative integers. This verifies that isInteger returns false for strings containing a '-' sign, as it currently only accepts digit-only strings. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:41:04 | BFLogBot Repo: bitfighter | Commit: 826a86daa9 | Author: eykamp | Message: Merge pull request #682 from bitfighter/fix-indentation-bug-1-14356986586326061648 Fix misleading indentation in bitfighter_test/main_test.cpp | |
| 16:55:08 | BFLogBot Repo: bitfighter | Commit: 57ea3bdeb1 | Author: google-labs-jules[bot] | Message: Fix bugs in stringUtils and add unit tests This commit fixes several logic bugs in `zap/stringUtils.cpp`: - `isInteger` now correctly handles `NULL` pointers and empty strings. - `extractExtension` now correctly handles paths where a directory name contains a dot but the filename does not, and returns an empty string when no extension is present. - `stripExtension` | |
| 16:55:10 | BFLogBot now correctly handles dots in directory names by ensuring only the extension in the filename is stripped. Added unit tests in `bitfighter_test/TestStringUtilsAI.cpp` and necessary stubs in `bitfighter_test/TnlStub.cpp` to verify these fixes. I am an AI agent assistant completing this task. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:55:15 | BFLogBot Pull request #683 opened by eykamp | Title: Fix stringUtils bugs and add unit tests (AI Agent) | https://github.com/bitfighter/bitfighter/pull/683 | |
| 16:56:06 | BFLogBot Repo: bitfighter | Commit: 12c73e4fab | Author: google-labs-jules[bot] | Message: Rename isInteger to isPositiveInteger to clarify behavior Since isInteger() returns false when passed a negative integer, this commit renames the function to isPositiveInteger() to more accurately reflect its behavior of only returning true for non-negative integers. Changes include: - Renamed isInteger() to isPositiveInteger() in zap/stringUtils.h and zap/stringU | |
| 16:56:07 | BFLogBot tils.cpp. - Updated all call sites in zap/GameRecorder.cpp and zap/ChatCommands.cpp. - Renamed a local variable firstArgIsInt to firstArgIsNumeric in zap/ChatCommands.cpp for consistency. - Added a new unit test case in bitfighter_test/TestStringUtils.cpp to verify the behavior of isPositiveInteger(). - Updated relevant documentation comments. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 16:56:09 | BFLogBot Pull request #684 opened by eykamp | Title: Rename isInteger() to isPositiveInteger() for clarity | https://github.com/bitfighter/bitfighter/pull/684 | |
| 17:01:01 | BFLogBot Comment on issue #683 | User: eykamp | Comment: These look ok, but the testing should be integrated into the ordinary test framework, rather than be off in some separat ... | https://github.com/bitfighter/bitfighter/pull/683#issuecomment-4194975039 | |
| 17:03:20 | BFLogBot Pull request #684 closed by eykamp | Title: Rename isInteger() to isPositiveInteger() for clarity | https://github.com/bitfighter/bitfighter/pull/684 | |
| 17:03:20 | BFLogBot Repo: bitfighter | Commit: 12c73e4fab | Author: google-labs-jules[bot] | Message: Rename isInteger to isPositiveInteger to clarify behavior Since isInteger() returns false when passed a negative integer, this commit renames the function to isPositiveInteger() to more accurately reflect its behavior of only returning true for non-negative integers. Changes include: - Renamed isInteger() to isPositiveInteger() in zap/stringUtils.h and zap/stringU | |
| 17:03:22 | BFLogBot tils.cpp. - Updated all call sites in zap/GameRecorder.cpp and zap/ChatCommands.cpp. - Renamed a local variable firstArgIsInt to firstArgIsNumeric in zap/ChatCommands.cpp for consistency. - Added a new unit test case in bitfighter_test/TestStringUtils.cpp to verify the behavior of isPositiveInteger(). - Updated relevant documentation comments. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:03:23 | BFLogBot Repo: bitfighter | Commit: d1239b0bbf | Author: eykamp | Message: Merge pull request #684 from bitfighter/rename-isinteger-to-ispositiveinteger-2669338325607484965 Rename isInteger() to isPositiveInteger() for clarity | |
| 17:05:18 | BFLogBot Comment on issue #683 | User: google-labs-jules[bot] | Comment: > These look ok, but the testing should be integrated into the ordinary test framework, rather than be off in some separ ... | https://github.com/bitfighter/bitfighter/pull/683#issuecomment-4194994994 | |
| 17:05:58 | BFLogBot Repo: bitfighter | Commit: f9e5a450ff | Author: google-labs-jules[bot] | Message: Integrate unit tests for stringUtils into mainline test suite This commit updates `bitfighter_test/TestStringUtils.cpp` to include comprehensive test cases for the fixes in `zap/stringUtils.cpp`, addressing previous feedback about test integration. The bugs fixed in `zap/stringUtils.cpp` include: - `isInteger` now correctly handles `NULL` pointers and empty string | |
| 17:05:59 | BFLogBot s. - `extractExtension` and `stripExtension` now properly handle paths by isolating the filename to prevent misidentifying dots in directory names. Removed temporary standalone test files and stubs. I am an AI agent assistant completing this task. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:08:25 | BFLogBot Comment on issue #683 | User: eykamp | Comment: Add a test for stripExtension("") ... | https://github.com/bitfighter/bitfighter/pull/683#issuecomment-4195009787 | |
| 17:11:42 | BFLogBot Repo: bitfighter | Commit: 43196e9634 | Author: google-labs-jules[bot] | Message: Fix bug in Zap::isInteger and add unit tests I'm an AI agent and I have fixed a bug in the Zap::isInteger function where it would incorrectly return true for an empty string and crash when a NULL pointer was passed. The fix involves adding checks for NULL and empty strings at the beginning of the function. I have also updated the existing bitfighter_test/TestStri | |
| 17:11:44 | BFLogBot ngUtils.cpp with more test cases to cover these scenarios. Testing: - Created and ran a standalone test (VerifyFixIsInteger.cpp) that links with zap/stringUtils.cpp to verify the fix manually, confirming that "123" is true, while "" and NULL are false. - Verified that the bitfighterd server target still builds correctly. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:11:45 | BFLogBot Pull request #685 opened by eykamp | Title: Fix bug in Zap::isInteger and add unit tests | https://github.com/bitfighter/bitfighter/pull/685 | |
| 17:12:05 | BFLogBot Comment on issue #683 | User: google-labs-jules[bot] | Comment: > Add a test for stripExtension("") I have added a test case for `stripExtension("")` to the `bitfighter_test/TestStrin ... | https://github.com/bitfighter/bitfighter/pull/683#issuecomment-4195026685 | |
| 17:12:52 | BFLogBot Repo: bitfighter | Commit: ab4df052ed | Author: google-labs-jules[bot] | Message: Add test for stripExtension("") This commit adds a specific unit test for `stripExtension("")` to ensure it returns an empty string as expected, improving test coverage for the recently added fixes in `zap/stringUtils.cpp`. I am an AI agent assistant completing this task. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:14:28 | BFLogBot Pull request #685 closed by eykamp | Title: Fix bug in Zap::isInteger and add unit tests | https://github.com/bitfighter/bitfighter/pull/685 | |
| 17:14:28 | BFLogBot Repo: bitfighter | Commit: 43196e9634 | Author: google-labs-jules[bot] | Message: Fix bug in Zap::isInteger and add unit tests I'm an AI agent and I have fixed a bug in the Zap::isInteger function where it would incorrectly return true for an empty string and crash when a NULL pointer was passed. The fix involves adding checks for NULL and empty strings at the beginning of the function. I have also updated the existing bitfighter_test/TestStri | |
| 17:14:29 | BFLogBot ngUtils.cpp with more test cases to cover these scenarios. Testing: - Created and ran a standalone test (VerifyFixIsInteger.cpp) that links with zap/stringUtils.cpp to verify the fix manually, confirming that "123" is true, while "" and NULL are false. - Verified that the bitfighterd server target still builds correctly. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:14:31 | BFLogBot Repo: bitfighter | Commit: 5007c81ee6 | Author: eykamp | Message: Merge pull request #685 from bitfighter/fix-isInteger-bug-10773156712985692279 Fix bug in Zap::isInteger and add unit tests | |
| 17:20:31 | BFLogBot Repo: bitfighter | Commit: 3c97e10f37 | Author: google-labs-jules[bot] | Message: Fix bugs in stringUtils: extractExtension, stripExtension, and isPositiveInteger. - extractExtension and stripExtension now correctly handle file paths with dots in directory names. - isPositiveInteger now handles NULL/empty strings safely. - Added isInteger as an alias for isPositiveInteger to match test expectations. - Added regression tests for these cases. I a | |
| 17:20:33 | BFLogBot m an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:20:35 | BFLogBot Pull request #686 opened by eykamp | Title: Fix bugs in string utility functions and add unit tests (AI Agent) | https://github.com/bitfighter/bitfighter/pull/686 | |
| 17:22:59 | BFLogBot Repo: bitfighter | Commit: 12c73e4fab | Author: google-labs-jules[bot] | Message: Rename isInteger to isPositiveInteger to clarify behavior Since isInteger() returns false when passed a negative integer, this commit renames the function to isPositiveInteger() to more accurately reflect its behavior of only returning true for non-negative integers. Changes include: - Renamed isInteger() to isPositiveInteger() in zap/stringUtils.h and zap/stringU | |
| 17:23:00 | BFLogBot tils.cpp. - Updated all call sites in zap/GameRecorder.cpp and zap/ChatCommands.cpp. - Renamed a local variable firstArgIsInt to firstArgIsNumeric in zap/ChatCommands.cpp for consistency. - Added a new unit test case in bitfighter_test/TestStringUtils.cpp to verify the behavior of isPositiveInteger(). - Updated relevant documentation comments. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:23:02 | BFLogBot Repo: bitfighter | Commit: d1239b0bbf | Author: eykamp | Message: Merge pull request #684 from bitfighter/rename-isinteger-to-ispositiveinteger-2669338325607484965 Rename isInteger() to isPositiveInteger() for clarity | |
| 17:23:03 | BFLogBot Repo: bitfighter | Commit: 43196e9634 | Author: google-labs-jules[bot] | Message: Fix bug in Zap::isInteger and add unit tests I'm an AI agent and I have fixed a bug in the Zap::isInteger function where it would incorrectly return true for an empty string and crash when a NULL pointer was passed. The fix involves adding checks for NULL and empty strings at the beginning of the function. I have also updated the existing bitfighter_test/TestStri | |
| 17:23:05 | BFLogBot ngUtils.cpp with more test cases to cover these scenarios. Testing: - Created and ran a standalone test (VerifyFixIsInteger.cpp) that links with zap/stringUtils.cpp to verify the fix manually, confirming that "123" is true, while "" and NULL are false. - Verified that the bitfighterd server target still builds correctly. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:23:06 | BFLogBot Repo: bitfighter | Commit: 5007c81ee6 | Author: eykamp | Message: Merge pull request #685 from bitfighter/fix-isInteger-bug-10773156712985692279 Fix bug in Zap::isInteger and add unit tests | |
| 17:23:08 | BFLogBot Repo: bitfighter | Commit: 3ae0e0c349 | Author: eykamp | Message: Merge branch 'master' into fix-string-utils-bugs-ai-agent-1452039642814603174 | |
| 17:23:21 | BFLogBot Pull request #683 closed by eykamp | Title: Fix stringUtils bugs and add unit tests (AI Agent) | https://github.com/bitfighter/bitfighter/pull/683 | |
| 17:28:41 | BFLogBot Pull request #686 closed by eykamp | Title: Fix bugs in string utility functions and add unit tests (AI Agent) | https://github.com/bitfighter/bitfighter/pull/686 | |
| 17:28:53 | BFLogBot Comment on issue #686 | User: eykamp | Comment: Too messy. ... | https://github.com/bitfighter/bitfighter/pull/686#issuecomment-4195111767 | |
| 17:32:42 | BFLogBot Comment on issue #686 | User: google-labs-jules[bot] | Comment: > Too messy. Acknowledged. I've refactored the changes to be much cleaner, using pointer arithmetic and project-specifi ... | https://github.com/bitfighter/bitfighter/pull/686#issuecomment-4195127808 | |
| 17:34:13 | BFLogBot Repo: bitfighter | Commit: ff8772f072 | Author: google-labs-jules[bot] | Message: Refactor and fix bugs in stringUtils: extractExtension, stripExtension, and isPositiveInteger. - extractExtension and stripExtension now correctly handle file paths with dots in directory names. - isPositiveInteger now handles NULL/empty strings safely and uses isDigit. - Added isInteger as an alias for isPositiveInteger to match test expectations. - Refactored imp | |
| 17:34:14 | BFLogBot lementations for better readability and cleaner code. - Added regression tests for these cases. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:47:58 | BFLogBot Repo: bitfighter | Commit: 9f49f81293 | Author: google-labs-jules[bot] | Message: Fix extractExtension/stripExtension bugs and implement isInteger - Updated extractExtension and stripExtension to correctly handle paths with dots in directory names. - Implemented missing isInteger function in zap/stringUtils. - Added comprehensive unit tests in bitfighter_test/TestStringUtils.cpp. - Verified changes with standalone Google Test runner. - Rationale | |
| 17:47:59 | BFLogBot : Ensure correct path handling and satisfy requirements for unit testing. - Identifier: AI Agent submission. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 17:48:01 | BFLogBot Pull request #687 opened by eykamp | Title: Fix string utility bugs and implement missing isInteger function | https://github.com/bitfighter/bitfighter/pull/687 | |
| 18:28:40 | BFLogBot Comment on issue #687 | User: eykamp | Comment: Why are you adding in the isInteger() function? Do we need it? ... | https://github.com/bitfighter/bitfighter/pull/687#issuecomment-4195358010 | |
| 18:29:50 | BFLogBot Comment on issue #687 | User: google-labs-jules[bot] | Comment: > Why are you adding in the isInteger() function? Do we need it? > I added the `isInteger()` function because it was ... | https://github.com/bitfighter/bitfighter/pull/687#issuecomment-4195362093 | |
| 18:30:36 | BFLogBot Repo: bitfighter | Commit: 5b12f5d6c8 | Author: google-labs-jules[bot] | Message: Address PR comment and finalize changes - Explained the addition of isInteger() in PR comments. - No further code changes required as isInteger() is necessary for existing unit tests. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 18:32:26 | BFLogBot Comment on issue #687 | User: eykamp | Comment: Please update the tests to use isPositiveInteger and remove the alias. ... | https://github.com/bitfighter/bitfighter/pull/687#issuecomment-4195371287 | |
| 18:35:30 | BFLogBot Comment on issue #687 | User: google-labs-jules[bot] | Comment: > Please update the tests to use isPositiveInteger and remove the alias. > I have updated the tests in `bitfighter_te ... | https://github.com/bitfighter/bitfighter/pull/687#issuecomment-4195381853 | |
| 18:35:54 | BFLogBot Repo: bitfighter | Commit: 880cdb9aee | Author: google-labs-jules[bot] | Message: Remove isInteger alias and update tests - Removed isInteger alias from zap/stringUtils.h and zap/stringUtils.cpp. - Updated bitfighter_test/TestStringUtils.cpp to use isPositiveInteger directly. - Verified all tests pass with standalone test runner. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 18:39:18 | BFLogBot Repo: bitfighter | Commit: 9f49f81293 | Author: google-labs-jules[bot] | Message: Fix extractExtension/stripExtension bugs and implement isInteger - Updated extractExtension and stripExtension to correctly handle paths with dots in directory names. - Implemented missing isInteger function in zap/stringUtils. - Added comprehensive unit tests in bitfighter_test/TestStringUtils.cpp. - Verified changes with standalone Google Test runner. - Rationale | |
| 18:39:19 | BFLogBot Pull request #687 closed by eykamp | Title: Fix string utility bugs and implement missing isInteger function | https://github.com/bitfighter/bitfighter/pull/687 | |
| 18:39:20 | BFLogBot : Ensure correct path handling and satisfy requirements for unit testing. - Identifier: AI Agent submission. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 18:39:21 | BFLogBot Repo: bitfighter | Commit: 5b12f5d6c8 | Author: google-labs-jules[bot] | Message: Address PR comment and finalize changes - Explained the addition of isInteger() in PR comments. - No further code changes required as isInteger() is necessary for existing unit tests. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 18:39:23 | BFLogBot Repo: bitfighter | Commit: 880cdb9aee | Author: google-labs-jules[bot] | Message: Remove isInteger alias and update tests - Removed isInteger alias from zap/stringUtils.h and zap/stringUtils.cpp. - Updated bitfighter_test/TestStringUtils.cpp to use isPositiveInteger directly. - Verified all tests pass with standalone test runner. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 18:39:24 | BFLogBot Repo: bitfighter | Commit: d5d6e21b06 | Author: eykamp | Message: Merge pull request #687 from bitfighter/fix-string-utils-and-is-integer-9666899310722501294 Fix string utility bugs and implement missing isInteger function | |
| 19:02:14 | BFLogBot Repo: bitfighter | Commit: d4c4c8b1c8 | Author: google-labs-jules[bot] | Message: Fix extension matching in getFilesFromFolder The `getFilesFromFolder` function in `zap/stringUtils.cpp` was incorrectly calling `extractExtension` on the filter strings provided in the `extensions` array. Since these filter strings are already expected to be extensions (e.g., "level"), calling `extractExtension` on them would return an empty string if they did not | |
| 19:02:16 | BFLogBot contain a dot, causing the filter to fail for valid files. This change modifies the function to use the filter strings directly (after lower-casing them) for comparison with the file's extension. A new unit test `getFilesFromFolder` has been added to `bitfighter_test/TestStringUtils.cpp` to verify the fix and ensure case-insensitive matching works as expected. I am an AI agent assisting with this task. Co-authored-by: eykamp <1133323+eykamp@u | |
| 19:02:17 | BFLogBot sers.noreply.github.com> | |
| 19:02:17 | BFLogBot Pull request #688 opened by eykamp | Title: Fix extension matching in getFilesFromFolder and add unit test | https://github.com/bitfighter/bitfighter/pull/688 | |
| 19:08:36 | BFLogBot Repo: bitfighter | Commit: a724d731bc | Author: eykamp | Message: Clarify comment for getFilesFromFolder function Updated comment to clarify file extension format for getFilesFromFolder function. | |
| 19:12:01 | BFLogBot Repo: bitfighter | Commit: 17006828d2 | Author: eykamp | Message: Enhance tests for getFilesFromFolder with case insensitivity Added test cases for mixed case file extensions. | |
| 19:12:31 | BFLogBot Comment on issue #688 | User: eykamp | Comment: Add a check to the tests you just wrote that confirm files and files2 are identical. ... | https://github.com/bitfighter/bitfighter/pull/688#issuecomment-4195506778 | |
| 19:14:29 | BFLogBot Comment on issue #688 | User: google-labs-jules[bot] | Comment: > Add a check to the tests you just wrote that confirm files and files2 are identical. Added a check to the `getFilesFr ... | https://github.com/bitfighter/bitfighter/pull/688#issuecomment-4195513470 | |
| 19:15:48 | BFLogBot Repo: bitfighter | Commit: 636d88f40c | Author: google-labs-jules[bot] | Message: Add identical results check to getFilesFromFolder test Updated the `getFilesFromFolder` unit test in `bitfighter_test/TestStringUtils.cpp` to include a check verifying that subsequent calls to the function return identical results, addressing the feedback from the PR review. I am an AI agent assisting with this task. Co-authored-by: eykamp <1133323+eykamp@users.n | |
| 19:15:49 | BFLogBot oreply.github.com> | |
| 19:17:37 | BFLogBot Comment on issue #688 | User: eykamp | Comment: We don't need to run it twice in a row and compare results; perhaps you didn't see the code I modified in the PR. Go ba ... | https://github.com/bitfighter/bitfighter/pull/688#issuecomment-4195523429 | |
| 19:19:17 | BFLogBot Comment on issue #688 | User: google-labs-jules[bot] | Comment: > We don't need to run it twice in a row and compare results; perhaps you didn't see the code I modified in the PR. Go ... | https://github.com/bitfighter/bitfighter/pull/688#issuecomment-4195528760 | |
| 19:20:59 | BFLogBot Repo: bitfighter | Commit: 45cdbd5468 | Author: google-labs-jules[bot] | Message: Update getFilesFromFolder test with mixed-case filter check Modified the `getFilesFromFolder` unit test in `bitfighter_test/TestStringUtils.cpp` to use mixed-case extension filters (e.g., `{"LeVeL", "tXt"}`) and removed the redundant run-and-compare check, addressing the latest feedback from the PR review. I am an AI agent assisting with this task. Co-authored-by | |
| 19:21:00 | BFLogBot : eykamp <1133323+eykamp@users.noreply.github.com> | |
| 19:23:24 | BFLogBot Pull request #688 closed by eykamp | Title: Fix extension matching in getFilesFromFolder and add unit test | https://github.com/bitfighter/bitfighter/pull/688 | |
| 19:23:24 | BFLogBot Repo: bitfighter | Commit: d4c4c8b1c8 | Author: google-labs-jules[bot] | Message: Fix extension matching in getFilesFromFolder The `getFilesFromFolder` function in `zap/stringUtils.cpp` was incorrectly calling `extractExtension` on the filter strings provided in the `extensions` array. Since these filter strings are already expected to be extensions (e.g., "level"), calling `extractExtension` on them would return an empty string if they did not | |
| 19:23:26 | BFLogBot contain a dot, causing the filter to fail for valid files. This change modifies the function to use the filter strings directly (after lower-casing them) for comparison with the file's extension. A new unit test `getFilesFromFolder` has been added to `bitfighter_test/TestStringUtils.cpp` to verify the fix and ensure case-insensitive matching works as expected. I am an AI agent assisting with this task. Co-authored-by: eykamp <1133323+eykamp@u | |
| 19:23:27 | BFLogBot sers.noreply.github.com> | |
| 19:23:29 | BFLogBot Repo: bitfighter | Commit: a724d731bc | Author: eykamp | Message: Clarify comment for getFilesFromFolder function Updated comment to clarify file extension format for getFilesFromFolder function. | |
| 19:23:30 | BFLogBot Repo: bitfighter | Commit: 17006828d2 | Author: eykamp | Message: Enhance tests for getFilesFromFolder with case insensitivity Added test cases for mixed case file extensions. | |
| 19:23:32 | BFLogBot Repo: bitfighter | Commit: 636d88f40c | Author: google-labs-jules[bot] | Message: Add identical results check to getFilesFromFolder test Updated the `getFilesFromFolder` unit test in `bitfighter_test/TestStringUtils.cpp` to include a check verifying that subsequent calls to the function return identical results, addressing the feedback from the PR review. I am an AI agent assisting with this task. Co-authored-by: eykamp <1133323+eykamp@users.n | |
| 19:23:33 | BFLogBot oreply.github.com> | |
| 19:23:35 | BFLogBot Repo: bitfighter | Commit: 45cdbd5468 | Author: google-labs-jules[bot] | Message: Update getFilesFromFolder test with mixed-case filter check Modified the `getFilesFromFolder` unit test in `bitfighter_test/TestStringUtils.cpp` to use mixed-case extension filters (e.g., `{"LeVeL", "tXt"}`) and removed the redundant run-and-compare check, addressing the latest feedback from the PR review. I am an AI agent assisting with this task. Co-authored-by | |
| 19:23:36 | BFLogBot : eykamp <1133323+eykamp@users.noreply.github.com> | |
| 19:23:38 | BFLogBot Repo: bitfighter | Commit: 79e6d3c373 | Author: eykamp | Message: Merge pull request #688 from bitfighter/fix-getfilesfromfolder-extension-matching-5951156684425225187 Fix extension matching in getFilesFromFolder and add unit test | |
| 20:13:19 | BFLogBot Repo: bitfighter | Commit: 971ff07f82 | Author: google-labs-jules[bot] | Message: Add comprehensive tests for stringUtils.cpp and verify existing functionality. - Implemented unit tests for over 40 functions and overloads in `zap/stringUtils.cpp`. - Verified correct behavior for path manipulation, numeric conversion, string replacement, casing, character checks, parsing, file I/O utilities, and alphanumeric sorting. - Confirmed `replaceString` c | |
| 20:13:20 | BFLogBot orrectly handles replacement strings containing the search string to prevent infinite loops. - Validated case-insensitive file search in `getFilesFromFolder`. - Documented key implementation patterns and environment-specific behaviors. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 20:13:25 | BFLogBot Pull request #689 opened by eykamp | Title: Comprehensive Unit Tests for stringUtils.cpp | https://github.com/bitfighter/bitfighter/pull/689 | |
| 20:20:34 | BFLogBot Repo: bitfighter | Commit: 07ac00f72c | Author: eykamp | Message: Add test case for extractDirectory and extractFilename | |
| 20:23:05 | BFLogBot Repo: bitfighter | Commit: 2ed62dfc18 | Author: eykamp | Message: Add test case for negative integer in toString | |
| 20:32:02 | BFLogBot Repo: bitfighter | Commit: 67ecbca813 | Author: eykamp | Message: Update TestStringUtils.cpp | |
| 20:33:59 | BFLogBot Repo: bitfighter | Commit: 090fd28239 | Author: eykamp | Message: Add comments for sorting comparators in tests Added comments to clarify the purpose of comparators in sorting tests. | |
| 20:35:10 | BFLogBot Pull request #689 closed by eykamp | Title: Comprehensive Unit Tests for stringUtils.cpp | https://github.com/bitfighter/bitfighter/pull/689 | |
| 20:35:11 | BFLogBot Repo: bitfighter | Commit: 971ff07f82 | Author: google-labs-jules[bot] | Message: Add comprehensive tests for stringUtils.cpp and verify existing functionality. - Implemented unit tests for over 40 functions and overloads in `zap/stringUtils.cpp`. - Verified correct behavior for path manipulation, numeric conversion, string replacement, casing, character checks, parsing, file I/O utilities, and alphanumeric sorting. - Confirmed `replaceString` c | |
| 20:35:12 | BFLogBot orrectly handles replacement strings containing the search string to prevent infinite loops. - Validated case-insensitive file search in `getFilesFromFolder`. - Documented key implementation patterns and environment-specific behaviors. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 20:35:14 | BFLogBot Repo: bitfighter | Commit: 07ac00f72c | Author: eykamp | Message: Add test case for extractDirectory and extractFilename | |
| 20:35:15 | BFLogBot Repo: bitfighter | Commit: 2ed62dfc18 | Author: eykamp | Message: Add test case for negative integer in toString | |
| 20:35:17 | BFLogBot Repo: bitfighter | Commit: 67ecbca813 | Author: eykamp | Message: Update TestStringUtils.cpp | |
| 20:35:18 | BFLogBot Repo: bitfighter | Commit: 090fd28239 | Author: eykamp | Message: Add comments for sorting comparators in tests Added comments to clarify the purpose of comparators in sorting tests. | |
| 20:35:20 | BFLogBot Repo: bitfighter | Commit: ca12e2e9d9 | Author: eykamp | Message: Merge pull request #689 from bitfighter/string-utils-tests-and-fixes-3310962229555754328 Comprehensive Unit Tests for stringUtils.cpp | |
| 20:47:48 | BFLogBot Repo: bitfighter | Commit: 2b2288ed0c | Author: google-labs-jules[bot] | Message: Fix bug in alphaNumberSort to correctly handle non-numeric strings. The previous implementation of alphaNumberSort incorrectly treated all non-numeric strings as having a value of 0, because it relied on atoi() without first checking if the string was actually a number. This caused non-numeric strings to be sorted before all positive integers, leading to a non-intu | |
| 20:47:49 | BFLogBot itive sorting order. The new implementation uses isPositiveInteger() to distinguish between numeric and non-numeric strings. It now sorts numbers before non-numeric strings, and correctly applies numerical or alphabetical sorting within each group. This change also includes additional unit tests in TestStringUtils.cpp to verify the fix and ensure consistent behavior for alphanumeric sorting. Co-authored-by: eykamp <1133323+eykamp@users.noreply | |
| 20:47:51 | BFLogBot .github.com> | |
| 20:47:53 | BFLogBot Pull request #690 opened by eykamp | Title: Fix alphaNumberSort to correctly handle non-numeric strings | https://github.com/bitfighter/bitfighter/pull/690 | |
| 21:12:17 | BFLogBot Repo: bitfighter | Commit: e876cf40de | Author: eykamp | Message: Update stringUtils.cpp | |
| 21:14:04 | BFLogBot Repo: bitfighter | Commit: 7447b23d93 | Author: eykamp | Message: Add test cases for alphaNumberSort function | |
| 21:14:50 | BFLogBot Pull request #690 closed by eykamp | Title: Fix alphaNumberSort to correctly handle non-numeric strings | https://github.com/bitfighter/bitfighter/pull/690 | |
| 21:14:50 | BFLogBot Repo: bitfighter | Commit: 2b2288ed0c | Author: google-labs-jules[bot] | Message: Fix bug in alphaNumberSort to correctly handle non-numeric strings. The previous implementation of alphaNumberSort incorrectly treated all non-numeric strings as having a value of 0, because it relied on atoi() without first checking if the string was actually a number. This caused non-numeric strings to be sorted before all positive integers, leading to a non-intu | |
| 21:14:52 | BFLogBot itive sorting order. The new implementation uses isPositiveInteger() to distinguish between numeric and non-numeric strings. It now sorts numbers before non-numeric strings, and correctly applies numerical or alphabetical sorting within each group. This change also includes additional unit tests in TestStringUtils.cpp to verify the fix and ensure consistent behavior for alphanumeric sorting. Co-authored-by: eykamp <1133323+eykamp@users.noreply | |
| 21:14:53 | BFLogBot .github.com> | |
| 21:14:55 | BFLogBot Repo: bitfighter | Commit: e876cf40de | Author: eykamp | Message: Update stringUtils.cpp | |
| 21:14:56 | BFLogBot Repo: bitfighter | Commit: 7447b23d93 | Author: eykamp | Message: Add test cases for alphaNumberSort function | |
| 21:14:58 | BFLogBot Repo: bitfighter | Commit: 6ddfce4887 | Author: eykamp | Message: Merge pull request #690 from bitfighter/fix-alphanumbersort-bug-16142960852572923125 Fix alphaNumberSort to correctly handle non-numeric strings | |
| 21:41:52 | BFLogBot Repo: bitfighter | Commit: 5279fcc3d9 | Author: Copilot | Message: Fix alphaNumberSort to handle strings with leading numeric portions Agent-Logs-Url: https://github.com/bitfighter/bitfighter/sessions/d33b7419-3cac-4e2a-893b-1769cb67288b Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> | |
| 21:42:33 | BFLogBot Pull request #691 opened by Copilot | Title: Fix alphaNumberSort to correctly sort strings with leading numeric portions | https://github.com/bitfighter/bitfighter/pull/691 |
Index Search ←Prev date Next date→
These logs were automatically created by BFLogBot on irc.freenode.net.