Page 1 of 1

/setserverpass and spaces

PostPosted: Sun Oct 19, 2014 9:32 pm
by sky_lark
Question about this, if I just type "/setserverpass " leaving a space right at the end, will the server recognize that command as (a) no password entered, thus open server for all or (b) me changing to the password to be a literal space that people still have to input, as in " "?

Re: Weekly Party: Bits o' Color RERUN - Friday 10/17

PostPosted: Mon Oct 20, 2014 7:19 am
by raptor
If there are just spaces after it, then it is considered 'clear password'

Re: Weekly Party: Bits o' Color RERUN - Friday 10/17

PostPosted: Mon Oct 20, 2014 12:13 pm
by sam686
might be a bug: /setserverpass " " isn't setting the password and only clears... But if you go to host menu and put a space in the password, that works for setting a password to just a space.

Another bug: fails to save passwords to bitfighter.ini that have just spaces and nothing else.

Re: Weekly Party: Bits o' Color RERUN - Friday 10/17

PostPosted: Tue Dec 23, 2014 9:58 pm
by watusimoto
might be a bug: /setserverpass " " isn't setting the password and only clears... But if you go to host menu and put a space in the password, that works for setting a password to just a space.

Another bug: fails to save passwords to bitfighter.ini that have just spaces and nothing else.


I don't have the source in front of me, but I think we trim the passwords to avoid spurious spaces. From the sound of it, we do it inconsistently, and maybe we shouldn't do it all.

If you really think this is a bug, please either fix it, or put a bug report in so it doesn't get forgotten.

Re: Weekly Party: Bits o' Color RERUN - Friday 10/17

PostPosted: Wed Dec 24, 2014 7:03 pm
by raptor
I don't think this is an issue - there are plenty of keys to choose from other than spaces for a password. Spaces are used for tokenization of commands and the effort to fix this is probably not worth for such an edge case.

Re: Weekly Party: Bits o' Color RERUN - Friday 10/17

PostPosted: Wed Dec 24, 2014 9:59 pm
by watusimoto
There does at the very least seem to be some inconsistent behavior that should be corrected, even if the overall design is the one we want to stick with.

Re: /setserverpass and spaces

PostPosted: Fri Dec 26, 2014 10:06 am
by amgine
Putting my two sense in.

1. it should be consistant bolth ways.

2. I have needed to use a space before though rare.