#bitfighter IRC Log

IRC Log for 2026-04-28

Timestamps are in GMT/BST.

07:24:20 BFLogBot Repo: bitfighter | Commit: efee2a490b | Author: google-labs-jules[bot] | Message: Fix stricmp/strnicmp signedness and over-read bugs - Cast characters to unsigned char before comparison in stricmp and strnicmp to ensure correct sorting of non-ASCII characters. - Add null-terminator check in strnicmp loop to prevent over-reading. - Add unit tests in TestStringUtils.cpp. Identified and fixed by an AI agent. Co-authored-by: eykamp <1133323+eykamp
07:24:22 BFLogBot @users.noreply.github.com>
07:24:24 BFLogBot Pull request #771 opened by eykamp | Title: Fix stricmp/strnicmp signedness and over-read bugs | https://github.com/bitfighter/bitfighter/pull/771
17:31:36 BFLogBot Pull request #771 closed by eykamp | Title: Fix stricmp/strnicmp signedness and over-read bugs | https://github.com/bitfighter/bitfighter/pull/771
17:31:36 BFLogBot Repo: bitfighter | Commit: e25b8ae9ae | Author: eykamp | Message: Fix stricmp/strnicmp signedness and over-read bugs (#771) - Cast characters to unsigned char before comparison in stricmp and strnicmp to ensure correct sorting of non-ASCII characters. - Add null-terminator check in strnicmp loop to prevent over-reading. - Add unit tests in TestStringUtils.cpp. Identified and fixed by an AI agent. Co-authored-by: google-labs-jules[bot] <1613698
17:31:37 BFLogBot 71+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
17:56:13 BFLogBot Repo: bitfighter | Commit: c1f8ca4a2d | Author: google-labs-jules[bot] | Message: Fix non-ASCII ordering and over-read bugs in stricmp/strnicmp This change fixes two bugs in the TNL platform-specific string comparison utilities: 1. stricmp and strnicmp now use unsigned char for character comparisons. This ensures correct magnitude comparison for non-ASCII characters (values > 127) on systems where char is signed. 2. strnicmp now correctly stops
17:56:14 BFLogBot at the null terminator, preventing potential memory over-reads when the requested length exceeds the actual string length. New unit tests in bitfighter_test/TestStringUtils.cpp verify the fixes: - stricmpOrderingNonASCII: Ensures 'a' sorts before '\xFF'. - strnicmpOverRead: Ensures strnicmp handles length larger than string. I am an AI agent assisting with these changes. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
17:56:15 BFLogBot Pull request #772 opened by eykamp | Title: Fix non-ASCII ordering and over-read bugs in stricmp/strnicmp | https://github.com/bitfighter/bitfighter/pull/772

Index Search ←Prev date Next date→

These logs were automatically created by BFLogBot on irc.freenode.net.

07:24:20		BFLogBot Repo: bitfighter \| Commit: efee2a490b \| Author: google-labs-jules[bot] \| Message: Fix stricmp/strnicmp signedness and over-read bugs - Cast characters to unsigned char before comparison in stricmp and strnicmp to ensure correct sorting of non-ASCII characters. - Add null-terminator check in strnicmp loop to prevent over-reading. - Add unit tests in TestStringUtils.cpp. Identified and fixed by an AI agent. Co-authored-by: eykamp <1133323+eykamp
07:24:22		BFLogBot @users.noreply.github.com>
07:24:24		BFLogBot Pull request #771 opened by eykamp \| Title: Fix stricmp/strnicmp signedness and over-read bugs \| https://github.com/bitfighter/bitfighter/pull/771
17:31:36		BFLogBot Pull request #771 closed by eykamp \| Title: Fix stricmp/strnicmp signedness and over-read bugs \| https://github.com/bitfighter/bitfighter/pull/771
17:31:36		BFLogBot Repo: bitfighter \| Commit: e25b8ae9ae \| Author: eykamp \| Message: Fix stricmp/strnicmp signedness and over-read bugs (#771) - Cast characters to unsigned char before comparison in stricmp and strnicmp to ensure correct sorting of non-ASCII characters. - Add null-terminator check in strnicmp loop to prevent over-reading. - Add unit tests in TestStringUtils.cpp. Identified and fixed by an AI agent. Co-authored-by: google-labs-jules[bot] <1613698
17:31:37		BFLogBot 71+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
17:56:13		BFLogBot Repo: bitfighter \| Commit: c1f8ca4a2d \| Author: google-labs-jules[bot] \| Message: Fix non-ASCII ordering and over-read bugs in stricmp/strnicmp This change fixes two bugs in the TNL platform-specific string comparison utilities: 1. stricmp and strnicmp now use unsigned char for character comparisons. This ensures correct magnitude comparison for non-ASCII characters (values > 127) on systems where char is signed. 2. strnicmp now correctly stops
17:56:14		BFLogBot at the null terminator, preventing potential memory over-reads when the requested length exceeds the actual string length. New unit tests in bitfighter_test/TestStringUtils.cpp verify the fixes: - stricmpOrderingNonASCII: Ensures 'a' sorts before '\xFF'. - strnicmpOverRead: Ensures strnicmp handles length larger than string. I am an AI agent assisting with these changes. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
17:56:15		BFLogBot Pull request #772 opened by eykamp \| Title: Fix non-ASCII ordering and over-read bugs in stricmp/strnicmp \| https://github.com/bitfighter/bitfighter/pull/772