#bitfighter IRC Log

IRC Log for 2014-09-27

Timestamps are in GMT/BST.

00:16:20 amgine123 Quit (Ping timeout: 246 seconds)
00:55:51 fordcars Night!
00:55:54 fordcars Quit (Quit: Page closed)
01:13:09 HylianSavior has joined
02:16:58 watusimoto has joined
02:16:58 ChanServ sets mode +o
02:40:39 raptor has joined
02:40:40 ChanServ sets mode +o
02:40:51 raptor this time i'll use the emscripten official SDK...
02:46:37 watusimoto Quit (Quit: Leaving.)
02:52:43 raptor Quit ()
03:42:36 HylianSavior Quit (Ping timeout: 244 seconds)
06:33:31 Destroyerimo has joined
07:43:12 LordDVG has joined
08:45:03 Destroyerimo_clo has joined
08:48:43 Destroyerimo Quit (Ping timeout: 246 seconds)
08:52:00 Destroyerimo has joined
08:53:38 Destroyerimo_clo Quit (Ping timeout: 244 seconds)
10:42:42 Destroyerimo_clo has joined
10:44:58 Nothing_Much Quit (Remote host closed the connection)
10:46:20 Destroyerimo Quit (Ping timeout: 246 seconds)
10:48:53 Nothing_Much has joined
10:58:04 Nothing_Much Quit (Remote host closed the connection)
10:58:58 Nothing_Much has joined
11:01:41 Nothing_Much Quit (Remote host closed the connection)
11:03:51 Nothing_Much has joined
11:08:21 Nothing_Much Quit (Remote host closed the connection)
11:10:00 Nothing_Much has joined
11:10:05 Nothing_Much Quit (Client Quit)
11:10:24 Nothing_Much has joined
11:12:14 Nothing_Much Quit (Remote host closed the connection)
11:13:12 Nothing_Much has joined
11:45:46 LordDVG Quit (Ping timeout: 245 seconds)
12:54:09 Nothing_Much Quit (Read error: Connection reset by peer)
13:05:26 Nothing_Much has joined
13:09:47 fordcars has joined
13:09:48 fordcars Quit (Client Quit)
13:10:02 fordcars has joined
14:06:16 amgine123 has joined
14:06:23 amgine123 hello
14:10:31 Destroyerimo has joined
14:10:31 Destroyerimo_clo Quit (Read error: Connection reset by peer)
14:22:53 Nothing_Much Quit (Remote host closed the connection)
14:57:17 amgine123 <.< .^.^.>.>
14:58:46 Nothing_Much has joined
15:00:32 fordcars Hi
15:05:25 Nothing_Much Hey fordcars
15:12:12 amgine123 hi fordcards
15:15:06 LordDVG has joined
15:36:26 fordcars Hey Nothing_Much
15:36:31 fordcars Hi amgine123
15:38:53 amgine123 sooo
16:24:40 Destroyerimo_clo has joined
16:28:17 Destroyerimo Quit (Ping timeout: 246 seconds)
16:41:08 amgine123 Quit (Quit: Page closed)
16:59:41 Destroyerimo_clo Quit (Read error: Connection reset by peer)
17:10:56 amgine123 has joined
17:35:33 amgine123 :)
18:03:06 LordDVG Quit (Remote host closed the connection)
18:42:03 Invisibl1 has joined
19:00:23 Invisibl1 Quit (Ping timeout: 260 seconds)
19:28:55 amgine123 Quit (Ping timeout: 246 seconds)
20:41:50 Invisible1 has joined
20:48:20 raptor has joined
20:48:20 ChanServ sets mode +o
20:48:37 raptor OK, I think it's official:  emscripten is *not* viable at the moment without significant work
20:49:22 raptor it's because they use SDL 1.3 which is no API compatible with SDL 1.2 or SDl2
20:49:26 raptor *SDL
20:49:45 raptor but SDL2 is being ported right now so maybe in a few months...
21:14:19 Invisible1 Quit (Ping timeout: 260 seconds)
21:24:38 fordcars raptor: really?
21:24:46 fordcars I hope it'll work
21:25:04 raptor hi, yeah...
21:25:12 raptor but i got much further this time...
21:25:13 fordcars Well, there is also tnl
21:25:19 fordcars How foar?
21:25:28 fordcars *far
21:25:33 raptor TNL was no problem except for the pthreads
21:25:41 fordcars Wow sweet
21:25:53 raptor that will have to take some thought, too...
21:25:59 raptor but doable, i think
21:26:16 fordcars But for networking, you'll use WebSockets?
21:26:29 raptor emscripten already handles that
21:26:36 fordcars Oh wow that is cool
21:26:57 raptor i made a huge mess of the codebase to get it to compile, though...
21:27:45 fordcars raptor: semms like sdl2 has already been ported: http://www.reddit.com/r/gamedev/comments/29ubya/emscripten_port_of_sdl2/
21:27:53 raptor sort of...
21:27:59 raptor that's what I compiled and tested with
21:28:06 fordcars Oh
21:28:10 raptor but it hasn't been integrated into emscripten yet
21:28:18 fordcars Wow you did go far
21:28:21 raptor so the SDL2 modifications are done
21:28:37 raptor but emscripten has to merge in stuff, too
21:28:55 raptor yeah...  i think I see a way forward now!  :)
21:29:04 raptor but it'll have to wait a time again
21:29:12 fordcars Yeah bummer :(
21:30:04 fordcars Oh wait, sdl2 handles networking?
21:30:19 raptor there is an SDL2_net library, i think, but we don't use it
21:30:34 fordcars Oh ok
21:30:40 raptor we use it for video and input
21:30:58 fordcars Interesting stuff though
21:31:23 fordcars Well, if it's only for input nd output, couldn't you hack some sort of tiny .js Sdl?
21:32:09 raptor want my latest output?
21:32:14 fordcars Oh sure
21:32:23 fordcars But does a server work or this it use sdl?
21:32:42 raptor i'm not sure about server stuff yet
21:32:47 raptor SDL is not used on the server
21:32:54 fordcars Would be interesting :P
21:35:44 raptor ok..  i will test a server compile...  since you've caught my interest  :)
21:35:57 fordcars Haha ok
21:36:02 fordcars Emscripten is amazing wow
21:36:18 fordcars OpenGl 1.x support
21:36:34 fordcars OpenGL ES 2.0 emulation
21:36:49 raptor ok, here is the output of my client attempt.  just extract and open it in a modern browser:  http://sam6.25u.com/upload/bf_emscripten.7z
21:37:24 fordcars Ok thanks!
21:39:12 raptor ha!  the server worked except it could not find any levels in a folder
21:39:25 raptor i mean it actually started up
21:39:44 raptor hmmm...  i wonder what to do with levels
21:39:44 fordcars Whoa!
21:39:55 fordcars There is a File System i think
21:40:00 raptor because a web app cannot access the system's filesystem
21:40:10 fordcars Try FS module
21:40:12 fordcars Wait
21:40:15 fordcars http://kripken.github.io/emscripten-site/docs/api_reference/Filesystem-API.html#filesystem-api
21:40:33 fordcars My guess is ou can have files in the html
21:40:40 fordcars *you
21:41:44 raptor ah yes
21:42:06 raptor I'd have to use those special API function just for emscripten
21:42:14 fordcars In the c++?
21:42:17 raptor yep
21:42:22 fordcars Oh neat
21:42:52 raptor and i'd have to preload data into the FS
21:43:30 fordcars That looks good
21:48:46 raptor if you've downloaded that 7z file above, you can load it and watch the browser console
21:48:58 raptor it'll spit out errors, like cannot initialize video driver
21:49:09 fordcars Yeah I tried it, it looks really cool
21:49:23 fordcars I tryied with the -dedicated argument too
21:49:44 fordcars in the html you can put arguments
21:49:53 raptor oh i didn't know that..
21:50:14 raptor so i got a lot farther this time...  but time to call it quits
21:51:56 fordcars What do you mean?
21:52:11 fordcars The server ran?
22:03:30 raptor i mean in my attempt at getting a client to run with emscripten
22:05:56 fordcars Oh okok
22:43:00 raptor i'm looking at your clone right now
22:43:14 raptor my first thought is that there seems to be an easier way to get the winning team...
22:43:20 raptor somewhere...
22:43:30 fordcars Oh wow
22:43:33 fordcars Thanks :P
22:43:45 fordcars Uh, maybe
22:43:52 fordcars It was just a quick and dirty thing
22:44:20 fordcars My version is heavy, there should be a mWinningTeam
22:44:32 raptor is it something you'd like to see merged in with trunk?
22:44:51 fordcars Whoa, it's too small for that isn't it?
22:45:06 raptor what do you mean, too small?
22:45:09 fordcars It looks like something you could write in 5 minutes
22:45:36 raptor if you've fixed or improved a bug, then I don't mind pulling in your code...  provided your code is decent enough  :)
22:45:36 fordcars Well, not worth merging
22:45:50 fordcars Haha, it's not very decent :P
22:46:23 fordcars I was just code-learning ;)
22:46:25 raptor so tell me - where you actually working on fixing an issue, or just tinkering a bit, or something else?  (i.e. what were your motivations for doing it)
22:46:30 raptor ah..  beat me to it!
22:46:35 fordcars Hahaha
22:46:47 fordcars I was trying to get to know classes a bit more
22:49:12 raptor well as soon as I compile it...  i'm going to review it  :)
22:49:24 fordcars Haha go ahead
22:53:38 raptor well..  so far so good..  it  compiles  :)
22:54:56 fordcars :D
22:56:08 raptor ok, i see a white border around the team color
22:56:12 raptor was that the change?
22:58:43 fordcars Yeah haha
22:58:47 fordcars Simple as that
22:59:33 raptor how invested are you in to getting this to work?  because I have some bugs and a better course of action to suggest  :)
23:00:12 fordcars It doesn't?
23:00:14 fordcars Oh wait
23:00:21 fordcars Did I forget to push again?
23:00:27 raptor i only have on commit
23:00:29 raptor *one
23:00:40 fordcars Yeah that might be it
23:00:44 raptor ha, ok
23:00:47 fordcars I had messed up a loop
23:00:50 raptor i'll await your push...
23:01:11 fordcars Oh never mind
23:01:17 fordcars I had pushed after :/
23:02:11 fordcars Haha, whaaat
23:02:24 fordcars It really doesn't work haha, I'll check it out
23:02:49 raptor yeah, i have a 2 team CTF game and the red team is *always* highlighted
23:02:58 fordcars Yep, did the same test :P
23:03:04 raptor if I may suggest a course of attack...
23:03:13 fordcars Sure, mWinningTeam?
23:03:23 fordcars That was what I had in minf
23:03:26 fordcars *mind
23:03:33 fordcars But I am sure you had a better idea :P
23:03:47 raptor yes, that, and also to check that only if the game is over
23:03:54 raptor there is a flag that is set once the level is won
23:03:55 fordcars Oh sure
23:04:03 raptor oh wait
23:04:03 fordcars Oh really?
23:04:21 raptor was the issue to show the currently winning team at any time?  or just when the match is over?
23:04:30 fordcars Just when the game is over
23:04:45 fordcars !bugs
23:04:45 BFLogBot To enter a bug: http://tinyurl.com/bfnewbug -- To view all bugs: http://tinyurl.com/bfbugs
23:05:53 fordcars https://code.google.com/p/bitfighter/issues/detail?id=168&sort=priority&start=100
23:07:13 raptor ok found it
23:07:25 raptor when rendering, use  getGame()->isGameOver()  to tell if the match is over
23:07:37 raptor if that is true, then do the highlighting
23:08:19 fordcars And is the winning team defined somewhere, or do I have to find it myself?
23:08:56 raptor yeah, it is...  let me look it up
23:10:29 raptor oh whoa, watusimoto rewrote this part...
23:10:35 raptor uhh...  looking elsewhere
23:10:41 fordcars Hah
23:10:58 fordcars Thanks for looking btw, it normally takes me 5 months
23:11:09 fordcars To find anything
23:11:24 raptor like this:  S32 winner = mGame->getTeamBasedGameWinner().second;
23:11:39 fordcars .second?
23:11:50 raptor mGame could be replaced with getGame()  and vice versa depending on what the current class uses
23:11:53 fordcars Oh, /first?
23:12:12 raptor that's part of the code - mGame->getTeamBasedGameWinner() returns a std::pair
23:12:17 fordcars Oh okokok
23:12:24 fordcars Ohhhh
23:12:25 raptor .first will return the team object i think, .second returns the team index
23:12:33 fordcars Multiple return values :)
23:12:41 fordcars Ok, I'll try it
23:12:44 raptor yeah
23:13:37 raptor actually the .first returns a winning enum with win/tied/etc.
23:13:43 raptor so .second is what you want
23:14:04 fordcars Oh cool
23:27:12 fordcars Hey raptor, just out of curiosity, why do this    static const S32 canvasHeight = DisplayManager::getScreenInfo()->getGameCanvasHeight();    static const S32 canvasWidth  = DisplayManager::getScreenInfo()->getGameCanvasWidth();
23:27:31 fordcars It gets DisplayManager::getScreenInfo() twice, isn't it faster to only get it once?
23:28:28 raptor sort of
23:28:41 raptor probably, yes
23:29:03 raptor so  ScreenInfo *screenInfo = DisplayManager::getScreenInfo()
23:29:12 raptor you'll probably find lots of lazy code  :)
23:29:22 fordcars Haha ok thanks :)
23:45:31 fordcars It works!
23:48:04 fordcars hg push says there aren't any changes?
23:48:15 raptor did you commit first?
23:48:19 fordcars Uh nope
23:48:21 raptor :)
23:48:28 fordcars Haha
23:49:42 fordcars Done!
23:54:22 raptor it works!
23:54:24 raptor ok
23:54:26 raptor now
23:55:07 fordcars Make it look prettier?
23:55:40 raptor in order to accept it you have to pass the monkeys with sticks who say your code must follow certain standards..
23:55:55 raptor so, here is what I see:
23:56:13 raptor 1.  we use 3 spaces instead of tabs in our code, so you need to remove the tabs
23:56:14 fordcars Sure
23:56:17 fordcars Oh yeah
23:56:24 fordcars That is Visual Studio shit
23:56:27 fordcars I enevr put those
23:56:31 fordcars Oh wait
23:56:33 raptor oh yeah, i hate that
23:56:39 fordcars tabs, yeah that is my fault
23:57:01 raptor there's some way to configure it but I don't know how...   I think sam686 does
23:57:49 raptor 2.  remove your added code from your earlier commit that you're not using anymore, i think at least the method AbstractTeam *Game::findWinningTeam()
23:57:59 fordcars Oh sure
23:58:52 raptor and any code pointing to it
23:59:03 raptor i like to review the last commit on google code so i know what to revert
23:59:39 raptor probably revert the teamInfo stuff, too

Index Search ←Prev date Next date→

These logs were automatically created by BFLogBot on irc.freenode.net.

00:16:20		amgine123 Quit (Ping timeout: 246 seconds)
00:55:51	fordcars	Night!
00:55:54		fordcars Quit (Quit: Page closed)
01:13:09		HylianSavior has joined
02:16:58		watusimoto has joined
02:16:58		ChanServ sets mode +o
02:40:39		raptor has joined
02:40:40		ChanServ sets mode +o
02:40:51	raptor	this time i'll use the emscripten official SDK...
02:46:37		watusimoto Quit (Quit: Leaving.)
02:52:43		raptor Quit ()
03:42:36		HylianSavior Quit (Ping timeout: 244 seconds)
06:33:31		Destroyerimo has joined
07:43:12		LordDVG has joined
08:45:03		Destroyerimo_clo has joined
08:48:43		Destroyerimo Quit (Ping timeout: 246 seconds)
08:52:00		Destroyerimo has joined
08:53:38		Destroyerimo_clo Quit (Ping timeout: 244 seconds)
10:42:42		Destroyerimo_clo has joined
10:44:58		Nothing_Much Quit (Remote host closed the connection)
10:46:20		Destroyerimo Quit (Ping timeout: 246 seconds)
10:48:53		Nothing_Much has joined
10:58:04		Nothing_Much Quit (Remote host closed the connection)
10:58:58		Nothing_Much has joined
11:01:41		Nothing_Much Quit (Remote host closed the connection)
11:03:51		Nothing_Much has joined
11:08:21		Nothing_Much Quit (Remote host closed the connection)
11:10:00		Nothing_Much has joined
11:10:05		Nothing_Much Quit (Client Quit)
11:10:24		Nothing_Much has joined
11:12:14		Nothing_Much Quit (Remote host closed the connection)
11:13:12		Nothing_Much has joined
11:45:46		LordDVG Quit (Ping timeout: 245 seconds)
12:54:09		Nothing_Much Quit (Read error: Connection reset by peer)
13:05:26		Nothing_Much has joined
13:09:47		fordcars has joined
13:09:48		fordcars Quit (Client Quit)
13:10:02		fordcars has joined
14:06:16		amgine123 has joined
14:06:23	amgine123	hello
14:10:31		Destroyerimo has joined
14:10:31		Destroyerimo_clo Quit (Read error: Connection reset by peer)
14:22:53		Nothing_Much Quit (Remote host closed the connection)
14:57:17	amgine123	<.< .^.^.>.>
14:58:46		Nothing_Much has joined
15:00:32	fordcars	Hi
15:05:25	Nothing_Much	Hey fordcars
15:12:12	amgine123	hi fordcards
15:15:06		LordDVG has joined
15:36:26	fordcars	Hey Nothing_Much
15:36:31	fordcars	Hi amgine123
15:38:53	amgine123	sooo
16:24:40		Destroyerimo_clo has joined
16:28:17		Destroyerimo Quit (Ping timeout: 246 seconds)
16:41:08		amgine123 Quit (Quit: Page closed)
16:59:41		Destroyerimo_clo Quit (Read error: Connection reset by peer)
17:10:56		amgine123 has joined
17:35:33	amgine123	:)
18:03:06		LordDVG Quit (Remote host closed the connection)
18:42:03		Invisibl1 has joined
19:00:23		Invisibl1 Quit (Ping timeout: 260 seconds)
19:28:55		amgine123 Quit (Ping timeout: 246 seconds)
20:41:50		Invisible1 has joined
20:48:20		raptor has joined
20:48:20		ChanServ sets mode +o
20:48:37	raptor	OK, I think it's official: emscripten is not viable at the moment without significant work
20:49:22	raptor	it's because they use SDL 1.3 which is no API compatible with SDL 1.2 or SDl2
20:49:26	raptor	*SDL
20:49:45	raptor	but SDL2 is being ported right now so maybe in a few months...
21:14:19		Invisible1 Quit (Ping timeout: 260 seconds)
21:24:38	fordcars	raptor: really?
21:24:46	fordcars	I hope it'll work
21:25:04	raptor	hi, yeah...
21:25:12	raptor	but i got much further this time...
21:25:13	fordcars	Well, there is also tnl
21:25:19	fordcars	How foar?
21:25:28	fordcars	*far
21:25:33	raptor	TNL was no problem except for the pthreads
21:25:41	fordcars	Wow sweet
21:25:53	raptor	that will have to take some thought, too...
21:25:59	raptor	but doable, i think
21:26:16	fordcars	But for networking, you'll use WebSockets?
21:26:29	raptor	emscripten already handles that
21:26:36	fordcars	Oh wow that is cool
21:26:57	raptor	i made a huge mess of the codebase to get it to compile, though...
21:27:45	fordcars	raptor: semms like sdl2 has already been ported: http://www.reddit.com/r/gamedev/comments/29ubya/emscripten_port_of_sdl2/
21:27:53	raptor	sort of...
21:27:59	raptor	that's what I compiled and tested with
21:28:06	fordcars	Oh
21:28:10	raptor	but it hasn't been integrated into emscripten yet
21:28:18	fordcars	Wow you did go far
21:28:21	raptor	so the SDL2 modifications are done
21:28:37	raptor	but emscripten has to merge in stuff, too
21:28:55	raptor	yeah... i think I see a way forward now! :)
21:29:04	raptor	but it'll have to wait a time again
21:29:12	fordcars	Yeah bummer :(
21:30:04	fordcars	Oh wait, sdl2 handles networking?
21:30:19	raptor	there is an SDL2_net library, i think, but we don't use it
21:30:34	fordcars	Oh ok
21:30:40	raptor	we use it for video and input
21:30:58	fordcars	Interesting stuff though
21:31:23	fordcars	Well, if it's only for input nd output, couldn't you hack some sort of tiny .js Sdl?
21:32:09	raptor	want my latest output?
21:32:14	fordcars	Oh sure
21:32:23	fordcars	But does a server work or this it use sdl?
21:32:42	raptor	i'm not sure about server stuff yet
21:32:47	raptor	SDL is not used on the server
21:32:54	fordcars	Would be interesting :P
21:35:44	raptor	ok.. i will test a server compile... since you've caught my interest :)
21:35:57	fordcars	Haha ok
21:36:02	fordcars	Emscripten is amazing wow
21:36:18	fordcars	OpenGl 1.x support
21:36:34	fordcars	OpenGL ES 2.0 emulation
21:36:49	raptor	ok, here is the output of my client attempt. just extract and open it in a modern browser: http://sam6.25u.com/upload/bf_emscripten.7z
21:37:24	fordcars	Ok thanks!
21:39:12	raptor	ha! the server worked except it could not find any levels in a folder
21:39:25	raptor	i mean it actually started up
21:39:44	raptor	hmmm... i wonder what to do with levels
21:39:44	fordcars	Whoa!
21:39:55	fordcars	There is a File System i think
21:40:00	raptor	because a web app cannot access the system's filesystem
21:40:10	fordcars	Try FS module
21:40:12	fordcars	Wait
21:40:15	fordcars	http://kripken.github.io/emscripten-site/docs/api_reference/Filesystem-API.html#filesystem-api
21:40:33	fordcars	My guess is ou can have files in the html
21:40:40	fordcars	*you
21:41:44	raptor	ah yes
21:42:06	raptor	I'd have to use those special API function just for emscripten
21:42:14	fordcars	In the c++?
21:42:17	raptor	yep
21:42:22	fordcars	Oh neat
21:42:52	raptor	and i'd have to preload data into the FS
21:43:30	fordcars	That looks good
21:48:46	raptor	if you've downloaded that 7z file above, you can load it and watch the browser console
21:48:58	raptor	it'll spit out errors, like cannot initialize video driver
21:49:09	fordcars	Yeah I tried it, it looks really cool
21:49:23	fordcars	I tryied with the -dedicated argument too
21:49:44	fordcars	in the html you can put arguments
21:49:53	raptor	oh i didn't know that..
21:50:14	raptor	so i got a lot farther this time... but time to call it quits
21:51:56	fordcars	What do you mean?
21:52:11	fordcars	The server ran?
22:03:30	raptor	i mean in my attempt at getting a client to run with emscripten
22:05:56	fordcars	Oh okok
22:43:00	raptor	i'm looking at your clone right now
22:43:14	raptor	my first thought is that there seems to be an easier way to get the winning team...
22:43:20	raptor	somewhere...
22:43:30	fordcars	Oh wow
22:43:33	fordcars	Thanks :P
22:43:45	fordcars	Uh, maybe
22:43:52	fordcars	It was just a quick and dirty thing
22:44:20	fordcars	My version is heavy, there should be a mWinningTeam
22:44:32	raptor	is it something you'd like to see merged in with trunk?
22:44:51	fordcars	Whoa, it's too small for that isn't it?
22:45:06	raptor	what do you mean, too small?
22:45:09	fordcars	It looks like something you could write in 5 minutes
22:45:36	raptor	if you've fixed or improved a bug, then I don't mind pulling in your code... provided your code is decent enough :)
22:45:36	fordcars	Well, not worth merging
22:45:50	fordcars	Haha, it's not very decent :P
22:46:23	fordcars	I was just code-learning ;)
22:46:25	raptor	so tell me - where you actually working on fixing an issue, or just tinkering a bit, or something else? (i.e. what were your motivations for doing it)
22:46:30	raptor	ah.. beat me to it!
22:46:35	fordcars	Hahaha
22:46:47	fordcars	I was trying to get to know classes a bit more
22:49:12	raptor	well as soon as I compile it... i'm going to review it :)
22:49:24	fordcars	Haha go ahead
22:53:38	raptor	well.. so far so good.. it compiles :)
22:54:56	fordcars	:D
22:56:08	raptor	ok, i see a white border around the team color
22:56:12	raptor	was that the change?
22:58:43	fordcars	Yeah haha
22:58:47	fordcars	Simple as that
22:59:33	raptor	how invested are you in to getting this to work? because I have some bugs and a better course of action to suggest :)
23:00:12	fordcars	It doesn't?
23:00:14	fordcars	Oh wait
23:00:21	fordcars	Did I forget to push again?
23:00:27	raptor	i only have on commit
23:00:29	raptor	*one
23:00:40	fordcars	Yeah that might be it
23:00:44	raptor	ha, ok
23:00:47	fordcars	I had messed up a loop
23:00:50	raptor	i'll await your push...
23:01:11	fordcars	Oh never mind
23:01:17	fordcars	I had pushed after :/
23:02:11	fordcars	Haha, whaaat
23:02:24	fordcars	It really doesn't work haha, I'll check it out
23:02:49	raptor	yeah, i have a 2 team CTF game and the red team is always highlighted
23:02:58	fordcars	Yep, did the same test :P
23:03:04	raptor	if I may suggest a course of attack...
23:03:13	fordcars	Sure, mWinningTeam?
23:03:23	fordcars	That was what I had in minf
23:03:26	fordcars	*mind
23:03:33	fordcars	But I am sure you had a better idea :P
23:03:47	raptor	yes, that, and also to check that only if the game is over
23:03:54	raptor	there is a flag that is set once the level is won
23:03:55	fordcars	Oh sure
23:04:03	raptor	oh wait
23:04:03	fordcars	Oh really?
23:04:21	raptor	was the issue to show the currently winning team at any time? or just when the match is over?
23:04:30	fordcars	Just when the game is over
23:04:45	fordcars	!bugs
23:04:45	BFLogBot	To enter a bug: http://tinyurl.com/bfnewbug -- To view all bugs: http://tinyurl.com/bfbugs
23:05:53	fordcars	https://code.google.com/p/bitfighter/issues/detail?id=168&sort=priority&start=100
23:07:13	raptor	ok found it
23:07:25	raptor	when rendering, use getGame()->isGameOver() to tell if the match is over
23:07:37	raptor	if that is true, then do the highlighting
23:08:19	fordcars	And is the winning team defined somewhere, or do I have to find it myself?
23:08:56	raptor	yeah, it is... let me look it up
23:10:29	raptor	oh whoa, watusimoto rewrote this part...
23:10:35	raptor	uhh... looking elsewhere
23:10:41	fordcars	Hah
23:10:58	fordcars	Thanks for looking btw, it normally takes me 5 months
23:11:09	fordcars	To find anything
23:11:24	raptor	like this: S32 winner = mGame->getTeamBasedGameWinner().second;
23:11:39	fordcars	.second?
23:11:50	raptor	mGame could be replaced with getGame() and vice versa depending on what the current class uses
23:11:53	fordcars	Oh, /first?
23:12:12	raptor	that's part of the code - mGame->getTeamBasedGameWinner() returns a std::pair
23:12:17	fordcars	Oh okokok
23:12:24	fordcars	Ohhhh
23:12:25	raptor	.first will return the team object i think, .second returns the team index
23:12:33	fordcars	Multiple return values :)
23:12:41	fordcars	Ok, I'll try it
23:12:44	raptor	yeah
23:13:37	raptor	actually the .first returns a winning enum with win/tied/etc.
23:13:43	raptor	so .second is what you want
23:14:04	fordcars	Oh cool
23:27:12	fordcars	Hey raptor, just out of curiosity, why do this static const S32 canvasHeight = DisplayManager::getScreenInfo()->getGameCanvasHeight(); static const S32 canvasWidth = DisplayManager::getScreenInfo()->getGameCanvasWidth();
23:27:31	fordcars	It gets DisplayManager::getScreenInfo() twice, isn't it faster to only get it once?
23:28:28	raptor	sort of
23:28:41	raptor	probably, yes
23:29:03	raptor	so ScreenInfo *screenInfo = DisplayManager::getScreenInfo()
23:29:12	raptor	you'll probably find lots of lazy code :)
23:29:22	fordcars	Haha ok thanks :)
23:45:31	fordcars	It works!
23:48:04	fordcars	hg push says there aren't any changes?
23:48:15	raptor	did you commit first?
23:48:19	fordcars	Uh nope
23:48:21	raptor	:)
23:48:28	fordcars	Haha
23:49:42	fordcars	Done!
23:54:22	raptor	it works!
23:54:24	raptor	ok
23:54:26	raptor	now
23:55:07	fordcars	Make it look prettier?
23:55:40	raptor	in order to accept it you have to pass the monkeys with sticks who say your code must follow certain standards..
23:55:55	raptor	so, here is what I see:
23:56:13	raptor	1. we use 3 spaces instead of tabs in our code, so you need to remove the tabs
23:56:14	fordcars	Sure
23:56:17	fordcars	Oh yeah
23:56:24	fordcars	That is Visual Studio shit
23:56:27	fordcars	I enevr put those
23:56:31	fordcars	Oh wait
23:56:33	raptor	oh yeah, i hate that
23:56:39	fordcars	tabs, yeah that is my fault
23:57:01	raptor	there's some way to configure it but I don't know how... I think sam686 does
23:57:49	raptor	2. remove your added code from your earlier commit that you're not using anymore, i think at least the method AbstractTeam *Game::findWinningTeam()
23:57:59	fordcars	Oh sure
23:58:52	raptor	and any code pointing to it
23:59:03	raptor	i like to review the last commit on google code so i know what to revert
23:59:39	raptor	probably revert the teamInfo stuff, too