Timestamps are in GMT/BST.
| 00:00:12 | raptor | oh and one more: |
| 00:00:33 | raptor | 3. single-line if / else control statements don't need brackets |
| 00:01:03 | raptor | so it would looke like this: |
| 00:01:04 | raptor | if(clientGame->isGameOver() && i == clientGame->getTeamBasedGameWinner().second) |
| 00:01:06 | raptor | isWinningTeam = true; |
| 00:01:07 | raptor | else |
| 00:01:09 | raptor | isWinningTeam = false; |
| 00:01:15 | fordcars | Oh sweet |
| 00:01:17 | raptor | ahh... and: |
| 00:01:25 | raptor | 4. no spaces between if and ( |
| 00:01:31 | raptor | or 'for' and ( |
| 00:01:43 | raptor | watusimoto was a stickler to me for that one... |
| 00:01:50 | fordcars | I'll try to figure out the VS settings :P |
| 00:02:00 | fordcars | It puts spaces everywhere |
| 00:08:19 | sam686 | raptor / fordcars: in visual studio: tools, options, text editor, c/c++, tabs, there is that option to keep spaces to 3 indent and tab size |
| 00:08:36 | fordcars | Ah nice, thanks! |
| 00:11:43 | raptor | back shortly.. |
| 00:47:02 | raptor | back |
| 00:51:55 | fordcars | I am finished, but winStatus == HasWinner doesn't work and I don't know why :/ |
| 00:52:19 | raptor | where was that? |
| 00:52:28 | fordcars | Sometimes it is Tied, but winStatus == HasWinner still returns true? |
| 00:52:37 | fordcars | Oh I just added it in the if statement |
| 00:52:51 | fordcars | const S32 winStatus = clientGame->getTeamBasedGameWinner().first; |
| 00:52:56 | raptor | ahhh |
| 00:53:25 | raptor | maybe put that in a bool outside of the if statemetn |
| 00:53:31 | raptor | then you can really see |
| 00:54:14 | fordcars | Ok I'll try |
| 00:57:28 | fordcars | Oh wair |
| 00:57:30 | fordcars | *t |
| 00:57:39 | fordcars | It has to do with the fact that there is one player |
| 00:57:42 | fordcars | Sorry! |
| 00:58:01 | raptor | ha! |
| 00:58:01 | fordcars | It's supposed to be that way I guess, since the other team has no players (when I tested) |
| 00:58:10 | raptor | yeah, probably |
| 01:00:04 | fordcars | Whoa Sudden Death! |
| 01:00:07 | fordcars | Fancy! |
| 01:00:14 | raptor | i've never hit that... |
| 01:00:18 | raptor | how did you trigger? |
| 01:00:34 | fordcars | One player (or more I guess) each team with a tie |
| 01:00:43 | raptor | hmm... |
| 01:01:32 | raptor | oooo fancy! |
| 01:01:38 | fordcars | Haha |
| 01:02:39 | fordcars | Ok pushed |
| 01:04:23 | raptor | looks good - did you still need those changes to teamInfo.cpp/.h ? |
| 01:06:07 | fordcars | Uh, I didn't find them! |
| 01:06:32 | raptor | see here: https://code.google.com/r/corteocarl-bugs/source/detail?r=2cee158277fa07f70756f7126c1fa41b177dfe16 |
| 01:06:43 | fordcars | Oh wait I got them |
| 01:08:36 | fordcars | I wasn't sure if I added that, but I did |
| 01:10:02 | raptor | ha! I found watusmoto's coding standards: http://bitfighter.org/wiki/index.php/GCI_Student_Bootstrap#Coding_Standards |
| 01:10:34 | fordcars | Hah! |
| 01:11:23 | fordcars | Ok raptor, nothing in teamInfo.cpp is mine anymore I believe |
| 01:11:46 | fordcars | Wait sorry! |
| 01:12:17 | fordcars | I added getTeamIndex(AbstractTeam *team) |
| 01:12:35 | fordcars | Should I leave it there? It could be useful |
| 01:12:48 | raptor | i'd undo it for now i think |
| 01:12:54 | fordcars | Sure |
| 01:13:29 | fordcars | Oh it's already gone |
| 01:14:15 | fordcars | I guess I'm clean |
| 01:14:23 | raptor | did you push? |
| 01:14:38 | fordcars | Yep |
| 01:15:17 | raptor | I don't see the reverted changes in teamInfo |
| 01:15:49 | fordcars | Really? |
| 01:15:58 | fordcars | It's not in my local clone |
| 01:16:15 | fordcars | Oh yes it is |
| 01:16:22 | fordcars | I am blind? |
| 01:17:02 | fordcars | Sorry about that |
| 01:18:01 | fordcars | I'll push in a few secs after compiling |
| 01:18:08 | raptor | ok |
| 01:23:26 | fordcars | Ok pushed |
| 01:26:14 | raptor | looks good! I'll merge |
| 01:27:59 | fordcars | Cool! |
| 01:39:47 | raptor | here it comes! |
| 01:39:56 | | BFLogBot Commit: 2cee158277 | Author: corteocarl | Message: First commit |
| 01:39:57 | | BFLogBot Commit: d6fd9b7b79 | Author: corteocarl | Message: Now works! |
| 01:39:59 | | BFLogBot Commit: df9be8176b | Author: corteocarl | Message: Updated to Bitfighter standards |
| 01:40:00 | | BFLogBot Commit: 5640cd31ab | Author: corteocarl | Message: Removed getTeamIndex from teamInfo |
| 01:40:02 | | BFLogBot Commit: 994390a954 | Author: buckyballreaction | Message: Minor whitespace changes to finish off fordcars' code to highlight the winning team on the scoreboard |
| 01:40:03 | | BFLogBot Commit: 406098177e | Author: buckyballreaction | Message: Merge |
| 01:40:56 | raptor | hey fordcars, was that your first code into our code base? |
| 01:41:16 | fordcars | Yay! |
| 01:41:21 | fordcars | Yeah it was :P |
| 01:41:29 | fordcars | Well if that small s_bot change doesn't count |
| 01:43:45 | raptor | do you have the dev badge? |
| 01:43:54 | fordcars | Nope :P |
| 01:44:14 | fordcars | The s_bot modification was pretty much one line |
| 01:45:19 | raptor | now you do :) |
| 01:45:33 | fordcars | Whoa thanks! |
| 01:45:41 | fordcars | My life is now accomplished |
| 01:45:45 | raptor | please try it out to make sure it's there :) |
| 01:45:51 | fordcars | Sure :P |
| 01:46:38 | fordcars | Yep, it's there with all it's glory |
| 01:46:44 | raptor | congrats! |
| 01:46:47 | raptor | and good job |
| 01:46:57 | fordcars | Thanks, this is awesome! |
| 01:47:09 | fordcars | Well it's all thanks to you devs, you are the ones that got me into coding |
| 01:47:44 | raptor | now you know that half of development is making sure the code is acceptable to the project owner :) |
| 01:47:56 | fordcars | Haha yep |
| 01:48:03 | raptor | the other half is being patient enough... |
| 01:48:32 | fordcars | Haha |
| 01:49:05 | fordcars | And searching through the code base for a method |
| 01:49:17 | raptor | oh man... yeah |
| 01:49:47 | raptor | I'm pretty good at finding things in the code... but I use an IDE that makes it easy (eclipse on Linux) |
| 01:49:59 | raptor | there's got to be some tricks in vc++ |
| 01:50:13 | raptor | i bet watusimoto could tell you how he searches code faster |
| 01:50:20 | fordcars | Probably |
| 01:50:26 | fordcars | I use Ctrl-f |
| 01:50:39 | fordcars | :) |
| 01:50:59 | raptor | there's some way to highlight a method and say "show me all the places this comes from" |
| 01:51:06 | raptor | or where it's used |
| 01:51:15 | fordcars | Yeah, show me all references, but it really shows all references |
| 01:51:20 | fordcars | Which is a lot :P |
| 01:51:38 | fordcars | Then you have to go through a long list |
| 02:01:34 | raptor | ok, heading to bed... night! |
| 02:01:45 | fordcars | I was going to say that too, night! |
| 02:01:49 | | raptor Quit () |
| 02:01:53 | | fordcars Quit (Quit: Page closed) |
| 02:21:06 | | Destroyerimo has joined |
| 02:26:52 | | Destroyerimo_clo has joined |
| 02:29:44 | | Destroyerimo Quit (Ping timeout: 244 seconds) |
| 03:00:57 | | Watusimoto has joined |
| 06:15:20 | | Watusimoto Quit (Ping timeout: 250 seconds) |
| 09:54:49 | | Nothing_Much Quit (Remote host closed the connection) |
| 09:58:20 | | Nothing_Much has joined |
| 12:00:22 | | fordcars has joined |
| 12:33:10 | | Watusimoto has joined |
| 12:37:25 | | Watusimoto Quit (Ping timeout: 260 seconds) |
| 13:15:52 | | Nothing_Much Quit (Read error: Connection reset by peer) |
| 13:29:32 | | Nothing_Much has joined |
| 14:06:39 | | LordDVG has joined |
| 15:26:16 | | Nothing_Much Quit (Remote host closed the connection) |
| 15:32:02 | | Nothing_Much has joined |
| 16:16:00 | | Watusimoto has joined |
| 16:21:30 | | Watusimoto Quit (Ping timeout: 260 seconds) |
| 16:52:21 | | LordDVG Quit (Ping timeout: 250 seconds) |
| 17:08:56 | | Watusimoto has joined |
| 17:26:13 | | LordDVG has joined |
| 17:50:39 | | Nothing_Much Quit (Read error: No route to host) |
| 17:51:07 | | Nothing_Much has joined |
| 17:58:35 | | Watusimoto_ has joined |
| 18:01:49 | | Watusimoto Quit (Ping timeout: 244 seconds) |
| 18:59:06 | | LordDVG Quit (Remote host closed the connection) |
| 19:36:23 | | Invisibl1 has joined |
| 19:40:47 | | Invisibl1 Quit (Ping timeout: 260 seconds) |
| 19:45:37 | | vs73nx has joined |
| 19:45:38 | | vs73nx Quit (Changing host) |
| 19:45:38 | | vs73nx has joined |
| 20:10:35 | | raptor has joined |
| 20:10:35 | | ChanServ sets mode +o |
| 20:10:40 | raptor | good evening |
| 20:15:49 | vs73nx | evening raptor |
| 20:16:02 | raptor | hi |
| 20:26:50 | Watusimoto_ | heyllo |
| 20:33:23 | raptor | heylow |
| 20:34:05 | fordcars | Hi |
| 20:37:01 | vs73nx | sup |
| 20:38:06 | raptor | Watusimoto_: I merged code from fordcars! (and gave him the dev badge) |
| 20:41:42 | fordcars | Haha :P |
| 20:53:23 | Watusimoto_ | I saw... he's changed is name! |
| 20:53:30 | Watusimoto_ | so fordcars, what does your code do? |
| 20:53:49 | Watusimoto_ | and congratulations, btw... we owe you a development badge, I think |
| 20:54:04 | Watusimoto_ | !nick watusimoto |
| 20:54:08 | | Watusimoto_ is now known as watusimoto |
| 20:54:20 | raptor | i gave him the badge |
| 20:54:23 | fordcars | Haha raptor gave me one :) |
| 20:54:23 | watusimoto | awesome |
| 20:54:34 | watusimoto | well, good job. I hope it wasn;t too traumatic |
| 20:56:29 | fordcars | It pretty much only changes the border of the winning team on game over in the score board |
| 20:56:45 | fordcars | watusimoto, I still have that "secret project" |
| 21:02:06 | raptor | i just learned something fun with mercurial - hg stash |
| 21:02:26 | raptor | if you have hg 2.8 or greater |
| 21:03:08 | raptor | if you have a bunch of working code but need to switch to another revision for some reason, you can just do 'hg stash' to save your changes temporarily, then switch and do what you need to do |
| 21:03:23 | raptor | then you can go back and do 'hg unstash' and tada! your modified code is back |
| 21:05:24 | watusimoto | I've seen hg stash before, and figured that's what it did... but good to have the confirmation |
| 21:05:44 | raptor | yeah, now i don't need to manage a dozen diff files |
| 21:17:24 | watusimoto | that's great... diffs can get messy |
| 21:18:06 | watusimoto | fordcars: as for the secret project, I still think it would be great, but I never thought of a better way to get the input points, and I think that's where you were hung up, no? |
| 21:20:31 | raptor | i still think a master server RPC to override certain basic color settings would be great |
| 21:20:46 | raptor | and maybe toggle certain designs |
| 21:20:55 | raptor | or even send the designs? |
| 21:35:26 | fordcars | watusimoto: yeah, it works fine, but the points just show an ugly shape |
| 21:35:33 | watusimoto | I think that would work fine. They would only be sent occasionally, could be client-side cached, etc. But we would need to design some sort of encoding protocol. |
| 21:54:37 | raptor | does the server maintain a list of IDs for the players that are connected... somewhere? |
| 21:57:52 | raptor | oh wait... voice chat is already guaranteed to be handled on a per-player basis... |
| 21:57:56 | raptor | nevermind |
| 21:59:15 | raptor | do RemoteClientInfos persist for the same player throughout a match? |
| 22:16:18 | watusimoto | I think they do |
| 22:16:35 | watusimoto | the ship object does not, but the clientinfo should |
| 22:16:46 | watusimoto | less sure about game-to-game |
| 22:17:08 | watusimoto | ok, got to go... will be back later |
| 22:17:13 | raptor | i vaguely remember them not persisting... but that you attempted to make them do so with a refactor.. |
| 22:17:15 | raptor | ok later! |
| 22:21:42 | | watusimoto Quit (Ping timeout: 260 seconds) |
| 22:36:29 | raptor | me too.. |
| 22:36:32 | | raptor Quit () |
| 22:41:38 | | Watusimoto has joined |