#bitfighter IRC Log

Index Search ←Prev date Next date→

IRC Log for 2013-04-28

Timestamps are in GMT/BST.

00:56:01bobdaduck_m has joined
00:56:15bobdaduck_mAnd not a shred of sense was programmed that day
00:56:59bobdaduck_mLevelgen carnival has the stupidest crashes
00:57:21bobdaduck_mApparently when Robbie gets close to the cotton candy machine the game crashes
00:57:34bobdaduck_mNEITHER OF WHICH HAVE ANYTHING TO DO WITH EACH OTHER
00:58:24bobdaduck_mexcept that cotton candy and robbie both calculate things based off where the center of the ship is.
00:59:29bobdaduck_mslashrant
00:59:54bobdaduck_m Quit (Client Quit)
01:10:29bobdaduckOH GOT IT
01:10:39bobdaduckBecause neutral ships levelgened zones make everything go boom
01:12:08bobdaduck Quit (Remote host closed the connection)
01:15:11Watusimoto Quit (Ping timeout: 248 seconds)
01:50:50raptor has joined
01:50:51ChanServ sets mode +o raptor
01:53:38raptorhowdy folks
01:53:56raptorcode review time..
01:55:01raptorok maybe i'm stupid.. because c++.. but what does having 'const' after a method mean again?
01:55:42raptor prays that the current revision compiles
01:57:16raptoryay
02:00:43kaenconst after a method means it can be called on a const instance of the class
02:01:32kaenhandy when you're passing around const refs
02:02:01kaenomg search forms are the devil
02:03:53raptorDIE SEARCH INTERFACES
02:04:14raptorconst is crazy
02:04:53raptorthanks
02:07:16kaenit's kind of unforgivable in cakephp, I mean there's already an explicit enumeration of the values, names, and types. All you need (logically) is maybe a whitelist of fields and a method in the controller and view. done
02:07:58kaenbut in reality (even using a "search" plugin written by a commercial development organization for cakephp) I have to build the whole thing by hand...
02:08:48raptortell me about it - I'm working on a search engine project at work
02:09:09kaenblech
02:09:12raptorthey paid a whole bunch of money for this system
02:09:35raptorand we'll have to write most of the interface from scratch anyways
02:10:43raptoroh kaen, did you actually do some testing with bobdaduck earlier?
02:10:49kaenjust a little
02:11:08kaenbouncer changes are great :)
02:11:15raptoroh good!
02:11:28raptorI sometimes think they're still a little too powerful?
02:11:42kaencould be
02:12:21raptordo you still want to do some testing?
02:12:25kaensure
02:12:33kaenI'll take a break from php for a bit
02:12:40raptorok, i'll start a server in gdb...
02:13:37kaenconnection terminated
02:13:54raptorok now try (i had a password on it)
02:58:22SolumnMushroom has joined
03:01:43SolumnMushroomInstalling Skype for linux
03:02:50SolumnMushroomOn Ubuntu
03:05:36SolumnMushroomAlso, happy Saturday!
03:07:11bobdaduck has joined
03:07:55raptorbugs bugs everywhere!
03:08:01raptorand hello
03:08:04SolumnMushroomSaturday has come and almost gone. It's 8 PM here
03:08:39SolumnMushroomPST
03:08:49raptoryeah, it's 9pm here
03:09:28raptorlots of peoples on!
03:09:51SolumnMushroomA whopping 4 people and 2 bots!
03:10:12SolumnMushroomNo offence to ChanServ or BFLogBot
03:20:40SolumnMushroom likes Ye Olde Pavement
03:35:02raptorso like, those games were great!
03:35:08kaenyep :)
03:35:22raptorlooked like a LAN party - all had 30 ping or lower except us
03:36:08kaenmost definitely...
03:37:02kaenI was dreaming today about having players (even just a few!) on 24/7
03:37:17raptoryeah - see, those games prove our game is pretty cool
03:37:41raptorbecause that was a lot of fun
03:38:18bobdaduckI figured out what was crashing levelgen carnival kaen
03:38:31kaenneutral ships + zones?
03:38:35bobdaduckYeah
03:38:45bobdaduckSee Robbie has a zone that moves with him
03:38:51bobdaduckand the neutral ship manning the cotton candy stand
03:38:51bobdaduckxD
03:38:58bobdaduckThat's fixed 019, right?
03:39:11raptoryes
03:39:23SolumnMushroomI now have checkinstall
03:39:40raptorbut with recent changes by watusimoto - I'm not confident in anything working quite right...
03:40:07bobdaduckOkay so I have 019 up. What should I test?
03:40:21raptorI can host a game - want to do some play testing?
03:40:27kaenyep
03:40:37bobdaduckPLAYTESTING 019
03:40:39bobdaduckOH BOY
03:40:41raptorserver up
03:40:43raptor69...
03:41:14bobdaduckI CAN'T TELL
03:41:19bobdaduckWHICH OF THE ONE SERVERS UP IS YOURS?
03:41:26raptoruh.. it starts with 69
03:41:29raptoronly one?
03:41:35bobdaduckxD
03:41:55raptorwhat the crazy
03:42:01raptorglobal chat doesn't work from in-game now..
03:45:07bobdaduckwhatttt
03:45:08bobdaduckxD
03:45:29SolumnMushroomBFLogBot I think that's your cue
03:45:47bobdaducklol
03:46:26SolumnMushroomI have a SEGA emulator
03:47:00SolumnMushroomAs for what SEGA stuff it emulates, the answer is "yes"
03:47:19SolumnMushroomKega Fusion
04:02:58bobdaduckcrash!
04:03:30bobdaduckIn clientInfo "isauthenticated"
04:03:39raptoroh lovely
04:03:47raptorcan you get me a trace?
04:05:28bobdaduckokay
04:05:30bobdaduckI got another crash
04:05:34bobdaduck...On my "testbugs" map
04:05:37bobdaduckHOW IRONIC.
04:05:54raptorare you testing within visual studio?
04:06:01bobdaduckyeah
04:06:05bobdaduckbottom right corner junk?
04:06:09raptoryes
04:06:11bobdaduckhttp://pastie.org/7731600
04:06:21raptorperfect!
04:06:26raptoryou can be taught!
04:06:52raptorrender errors, argh
04:07:08kaenyuck
04:07:15kaenwhich level was that on?
04:07:16raptoryeah, i don't like the trace
04:08:05bobdaduckuh
04:08:11raptoryeah, bugs everywhere
04:08:33kaenfrankly, not a great trace format. where are the filenames?
04:08:47raptorbobdaduck: kill me please - i'm stuck in 'press any key to respawn'
04:08:54bobdaduckOkay so testbugs apparently
04:09:01bobdaduckis the map where
04:09:12kaengotta go, will read the logs
04:09:14bobdaduckI have the slipzone with negative slip coeficcient
04:09:50bobdaduckWith a neutral ship in it
04:10:03bobdaduckhere's the crash on levelgen carnival:
04:10:03bobdaduckhttp://pastie.org/7731607
04:10:41raptorsame
04:10:43raptorok
04:10:44raptorthanks
04:11:03raptorbobdaduck
04:11:10raptorcan you check one of the other vc++ tabs
04:11:28raptorto see if there is a better trace - it'll be similar, but have filenames, too
04:11:29bobdaduckwhich one
04:11:35raptori have no idea...
04:11:58bobdaduckCall stack (the one I gave), BreakPoints, command window, immediate window, output
04:12:13raptorok, call stack would be it..
04:12:15raptorboo
04:12:26bobdaduckhm maybe
04:12:38bobdaduck"Autos" has a collapsable
04:12:52bobdaduck0x0000000 {mplayerInfo = ??? mstatistics = {...} etc
04:12:59raptorooo
04:13:01bobdaduckthis 0x00000000 {mPlayerInfo=??? mStatistics={...} mShip={...} ...} Zap::ClientInfo * const
04:13:07raptoryeah, that's a 'complete' stack trace
04:13:11raptorthat'll be good too
04:13:32bobdaduckhow big should I make it? xD
04:13:51raptoruhh, maybe only like 20 or so lines of the complete one
04:14:06raptorwith the normal call stack
04:14:15bobdaducktoo late
04:14:15bobdaduckhttp://pastie.org/7731611
04:14:45raptorha
04:14:55raptorok, so that says clientinfo is null
04:14:57raptorman
04:15:00raptorsoo many bugs
04:15:12raptorkaen: do you think the issues could be just because of all the 'const' additions?
04:15:27bobdaduckI'MA GO FIND SOME MORE
04:15:32bobdaduck(he's gone)
04:21:05raptoryour mine room isn't working..
04:21:40SolumnMushroomI have Steam, Minecraft, Skype, and a good Sega console emulator as well as an IRC client AND Bitfighter! I think I'm good on entertainment
04:22:27raptorbobdaduck: i've crashed your script at least twice now..
04:26:19bobdaduckhow?
04:26:26raptori don't know...
04:26:57raptoroh, i think once it was because i crash, then rejoined the server
04:27:10raptormy ghost was already there, so it kicked it
04:27:16SolumnMushroomGoodnight
04:27:21SolumnMushroom Quit (Quit: Leaving)
04:27:29raptorthen the script crash
04:28:16raptorcrahsed again
04:32:33raptorok, coming back, is script working?
04:46:25raptorcrash!
04:46:30bobdaduckDid you?
04:46:40bobdaduckI changed the level to space station
04:46:46raptorah... ok, just long level load then
04:46:49bobdaducklol
04:54:31bobdaduckOwner comands is empty
04:54:35bobdaduckin F1
04:54:40raptorwhat!?
04:54:52bobdaduck /shutdown should be an owner command.
04:54:55bobdaduck(just thoughts.
04:55:08raptori had commands there when i coded it!
04:55:12bobdaducklol
04:55:16bobdaduckits totally empty.
04:55:18bobdaduckANYWAY.
04:55:34raptorman
04:55:44raptori can't write these bugs down fast enough!
04:55:53bobdaduckxD
04:56:08raptorwait, is it playerInfo that is used on onShipLeftZone?
04:56:08bobdaduckwe didn't even TRY dnd
04:56:21raptorand that is used to register players?
04:56:53raptoryep, that's it..
05:02:23bobdaduckprobablly
05:02:29bobdaducknowait
05:02:42bobdaduckno onshipleftZone has ship, not playerInfo
05:02:54bobdaduckand then playerinfo is used to register players
05:03:14raptoryes, so we know at least the playerinfo is different all the time
05:03:37raptorok, wrote down all the bugs
05:03:50raptorsent watusimoto an e-mail about why the game is broken so much...
05:04:08bobdaduckxD
05:04:38raptorok, brain shutting down
05:04:40raptornight!
05:05:04raptorif you find anymore bobdaduck, don't hesitate to post them here - i'll check the logs
05:05:10bobdaducklolk
05:05:11raptor*any more bugs
05:05:34raptor Quit ()
05:08:29bobdaduck Quit (Remote host closed the connection)
05:58:22Platskies has joined
07:46:10Platskies Quit (Remote host closed the connection)
08:55:04Watusimoto has joined
09:31:04LordDVG has joined
09:54:33Watusimoto Quit (Ping timeout: 276 seconds)
11:13:39LordDVG Quit (Remote host closed the connection)
12:08:19Watusimoto has joined
12:24:15Platskies has joined
12:37:12Platskies Quit (Remote host closed the connection)
12:54:54Watusimoto Quit (Ping timeout: 248 seconds)
12:55:24kaen looks at the RBL
12:55:42kaen sobs
13:49:45koda has joined
14:43:56Watusimoto has joined
15:44:07koda Quit (Quit: koda)
16:13:21bobdaduck has joined
16:13:22bobdaduck_ has joined
16:16:10bobdaduck_ Quit (Remote host closed the connection)
16:17:39bobdaduckSo watusimoto
16:17:42bobdaduckdid you see?
16:17:49Watusimotohey there
16:17:50bobdaduck(the logs)
16:17:56Watusimotono
16:18:05bobdaduckOh.
16:18:11Watusimotowhat to see? the crashes?
16:18:12bobdaduckWell. in 019 you can move while typing
16:18:17Watusimotofixed
16:18:18bobdaduckThere were plenty of crashes
16:18:26WatusimotoI know the problem, am working on it now
16:18:42Watusimotowell, at leat the typing one
16:18:59Watusimotoworking on the resource item one now... I suspect its related, but not sure how yet
16:20:42bobdaduckWhich resource item one?
16:22:44Watusimotopick up resource item, client still renders it where it was
16:22:46Watusimotoit's on the list
16:54:17Watusimotofound it!!!\
16:54:22Watusimotonot const related!!!
17:01:44Watusimotomaybe I can figure out how to fix it after dinner...
17:02:17Watusimotouploading some const fixes... may fix some of the crashes. or not??
17:02:38BFLogBot Commit: 560229591daa | Author: watusimoto | Message: Make static var non-static
17:02:40BFLogBot Commit: afc6cc8e6f93 | Author: watusimoto | Message: Add some welcome and intro messages
17:02:41BFLogBot Commit: 142824134fb9 | Author: watusimoto | Message: Moved help messages over to X-macro type structure
17:02:42Watusimotoback later
17:02:43BFLogBot Commit: ea43ee29a80a | Author: watusimoto | Message: Add some missing const declarations -- caused overrides to not override. Let to mayhem and zany antics.
17:07:56Watusimoto Quit (Ping timeout: 255 seconds)
17:10:32kaenbobdaduck, thoughts? http://bitfighter.org/pleiades/
17:10:40kaenadded level info and a rudimentary search
17:17:08bobdaduckhm
17:17:08bobdaducksec
17:17:33kaenmake sure to deep refresh
17:18:07bobdaduckThe colors are nice
17:18:18kaenlol that's my least favorite part
17:18:37bobdaducklol
17:18:41bobdaduckCan't search by author
17:19:17bobdaduckHome and search... Shouldn't there be view all levels or somesuch?
17:20:02kaenwe agreed that view all levels is worthless
17:20:08kaenalso, search defaults to all levels
17:20:21bobdaducktrue but I feel like just "home" as the only screen is kind of...
17:20:32kaenall that we need?
17:20:37bobdaducknot enough.
17:20:41bobdaduckaesthetically.
17:20:53kaenI should make up another page?
17:21:03bobdaduckYeah.
17:21:04kaenpleiades/kittens
17:21:11bobdaduckMaybe some "random levels" or something
17:22:51bobdaduckLike right now it doesn't feel like there's a way to browse.
17:22:58bobdaduckI mean yes there is but it doesn't feel like it.
17:23:12bobdaduckIts like either you're chilling in the lobby or you're searching for a specific level.
17:24:19bobdaduckAnd no inbetween
17:25:31kaenhow might one browse them?
17:26:05bobdaduckI dunno
17:26:16bobdaduckProbably by gametype just like we have in the forums
17:26:33bobdaduckI think just have each of the tags and pull some random sample levels from each
17:32:05kaenauthor search works now...
17:32:30kaenI didn't add it because I was planning on have user pages which would list recent comments, ratings, uploaded maps, favorites, etc
17:33:00kaenbobdaduck are you able to manually set the author?
17:34:54bobdaduckyeah
17:35:19kaenhmm odd I thought I set it so only phpbb admins are able to
17:36:18bobdaduckI'm an admin
17:36:46kaenoh lol
17:36:52kaenwell then perfect
17:37:09kaenI already know normal users can't
17:37:55koda has joined
17:38:36kaenso I was thinking about renaming it "galaxy"
17:38:48bobdaduckI like "playedes"
17:38:56kaenplaya-des?
17:39:00kaen:)
17:39:10bobdaduckplayed-s
17:39:24kaenI like it, but it's unspellable
17:39:40bobdaduckyeahhh
17:39:43bobdaduckgalaxy is good
17:39:43kaenalso galaxy is shorter and everyone knows what it means
17:39:54kaenI know it's lamer than pleiades
17:40:19kaenbut it's kind of important that people can refer to it by name easily...
17:40:30bobdaduckyeah
17:52:37Watusimoto has joined
17:58:18bobdaduck Quit (Read error: Connection reset by peer)
18:05:05BFLogBot Commit: df2f75c71257 | Author: watusimoto | Message: Fix improper rendering of carried resource items. Vaguely interesting fix.
18:18:43BFLogBot Commit: 4e86c0b52c13 | Author: watusimoto | Message: Fix missing owner commands -- were removed by a merge gone wrong some days ago
18:24:27raptor has joined
18:24:27ChanServ sets mode +o raptor
18:27:29raptorhowdy folks
18:27:37raptoroh good, bug fixing!
18:30:41Watusimotohi
18:30:45Watusimotosorry about all the bugs
18:30:50WatusimotoI think all i fixed were my fault
18:30:54Watusimotothough all for different reasons
18:30:59raptorhello
18:31:07raptorthat's ok
18:31:18WatusimotoNot sure about the segfaults
18:31:21Watusimotodo they recur?
18:31:30raptorit did feel, however, that we passed a threshold of buginess in 019...
18:31:37Watusimotoha
18:31:44raptorso I should stop adding features and work on bugs..
18:31:51raptorlet me pull and compile..
18:32:13Watusimotothe lua related shutdown segfault is particuarly confusing
18:32:16Watusimotoit should not happen
18:32:33Watusimotoif that recurs, one thing to try would be to turn on debugging asserts in lua
18:32:42raptori've had it happen twice
18:32:53Watusimotonot sure how to do that, but... I'll look into it
18:32:56raptorboth required i spend some amount of time in the editor and run plugins
18:33:33Watusimotoah, i see
18:33:41raptorbut just opening the editor, running plugins, then exiting didn't make it happen
18:33:47Watusimotoperhaps some lingering problem that doesn';t reaveal itself until cleanup time
18:34:23raptoryeah
18:35:13Watusimotosince this is on shutdown, if we can't figure out the problem, we could just try/catch it and just ignore any errors
18:35:33Watusimotothough that's kind of a cop out
18:35:39raptorcompiled! ok testing bugs again..
18:36:07raptorcould it be LuaW and garbage collection?
18:36:54Watusimotomaybe
18:37:18Watusimotolooking at the line that crashed, I'm not sure how
18:37:18Watusimotoif (!(iswhite(curr) || all) || isfinalized(gco2u(curr)))
18:37:35raptorwhat the..
18:37:39Watusimotoall is an int, curr is a poitner to a GC object (it looks like)
18:38:12Watusimotoif the crash happened inside one fo those functions, I'd expect to see it in the stack trace
18:38:33WatusimotoI just don't see how that could crash there
18:38:52Watusimotoeven if the pointers are null
18:38:54raptoryeah, it was really weird
18:38:57Watusimotoor garbage
18:39:16raptori'm thinking we're gonna have to valgrind this release..
18:40:06WatusimotoI really hate how every function is a freakin' #define to something else
18:40:24raptoryeah... preprocess the code away completely!
18:40:28Watusimotoah, I see now
18:40:32Watusimotostupid #defines
18:41:13Watusimotogco2u is really &rawgco2u(o)->uv
18:41:26Watusimotoso if rawgco2u(o) were null, it could crash
18:42:28Watusimotoand look... iswhite is defined to be test2bits((x)->gch.marked, WHITE0BIT, WHITE1BIT)
18:42:52Watusimotoso if curr were null it could crash also
18:43:19Watusimotothough curr is checked for null earlier, so that's not the issue
18:43:31Watusimotoand oh look
18:43:42Watusimotoisfinalized is ALSO a #define
18:43:50Watusimototestbit((u)->marked, FINALIZEDBIT)
18:44:10Watusimotoso, really, there are several reasons this could crash
18:44:21Watusimotoall well hidden away under a crappy macro language
18:45:42Watusimotooh and look, rawgco2u(o) is a macro too!
18:45:54Watusimotothat's defined as check_exp((o)->gch.tt == LUA_TUSERDATA, &((o)->u))
18:45:59Watusimotoand... you guessed it!
18:46:07Watusimotocheck_exp is a macro
18:46:23raptorhaHAha
18:46:47Watusimotook, well, this is actually kind of interesting
18:46:55Watusimotobecause check_exp is defined as thus:
18:47:01Watusimoto#define check_exp(c,e) (e)
18:47:04Watusimotowhich seems kind of lame
18:47:07Watusimotobut
18:47:23Watusimotoif we define lua_assert, it gets defined as this
18:47:23Watusimoto#define check_exp(c,e) (lua_assert(c), (e))
18:47:44Watusimotoso it appears that turning on lua_assert might actually check some of the things that we need to have checked
18:48:12raptorhttp://stackoverflow.com/questions/277258/c-c-source-file-after-preprocessing
18:48:12raptorwhat
18:49:16WatusimotoI've done that before, it's really big and messy
18:49:26raptorblech
18:49:32Watusimotobut let's enable lua_assert for a while and see if it helps
18:50:14raptorok, you'll do that? (I'm not sure how at the moment..)
18:50:42raptorupdateInterpolation... odd
18:54:36raptorF5 global chat in-game is still broken
18:54:58Watusimotosure, I'll do it
18:55:02Watusimotohow is it broken?
18:55:12Watusimotoyou press f5 and what happens?
18:55:12raptoryou join a game, press F5... nothing happens
18:55:25Watusimotodoes it work when hosting?
18:55:28raptorI did a full recompile from the latest
18:55:31raptorchecking..
18:55:45raptornope, doesn't work from hosting either
18:55:58Watusimotoodd... works for me
18:56:15Watusimotochecking agian
18:56:48Watusimotostill works. i can see little apple on there
18:57:03raptor recommends a full recompile
18:57:15WatusimotoI don't want to break it!
18:57:15raptorbobdaduck had the same issue last night, he had to do a full recompile
18:57:19raptorhaha
19:01:51Watusimotook, will rebuild now
19:01:57BFLogBot Commit: e9b2307c44b0 | Author: watusimoto | Message: Magic numbers
19:01:59BFLogBot Commit: 8cb8aacd6708 | Author: watusimoto | Message: Attempt to enable tnl_assert when in debug mode
19:02:24Watusimotonot sure my lua fix will work
19:02:40Watusimotowe could take out the ifdef if it doesn;t appear to be getting defined
19:07:37raptorthat define might need to be in a header or used as a compiler flag..
19:09:19BFLogBot Commit: 5fc0a8e250bb | Author: buckyballreaction | Message: Make /shutdown an Owner command
19:09:40raptoryeah, that define won't work.. :(
19:09:48raptori'll adjust it..
19:16:31Watusimotoafter a full rebuild (with the assert in question), F5 still works fine
19:28:01raptorhuh
19:31:07raptoryeah... f1, f2, f6, f7 all work
19:31:08raptornot f5
19:31:30raptoralso - is f6 (fps screen) supposed to be a fancy box?
19:32:25BFLogBot Commit: 9d3327fa9742 | Author: buckyballreaction | Message: Actually enable lua_assert
19:51:30raptorback in a bit..
19:56:10raptor Quit (Ping timeout: 268 seconds)
20:52:01raptor has joined
20:52:03ChanServ sets mode +o raptor
21:03:10raptorhello again
21:11:50raptorso i got another weird segfault after using the editor.. this makes 3 completely different ones
21:15:18BFLogBot Commit: a577d5188308 | Author: buckyballreaction | Message: Fix some crashes with ClientInfo being NULL
21:24:43BFLogBot Commit: 9ca6e0e087ed | Author: buckyballreaction | Message: Merge upstream Font-Stash changes to fix fullscreen font artifacts on Mac/Linux
21:32:32raptoryay, fontstash guy found and fixed the bug!
21:41:43Watusimotoexcellent!
21:42:06raptorand I wasn't crazy! (for once)
21:42:16Watusimotothank goodness for other people's code!
21:42:26raptoryes!
21:47:19Watusimotobtw, have you seen enough of the new help system to have an idea if you like it or not?
21:47:37raptorwell, we need an option to turn it off :)
21:47:43Watusimotoof course
21:47:44raptorbut it's coming along nicely..
21:47:54Watusimotodo you think it's the right approach?
21:50:36raptorseems good to me
21:50:56raptorit'll need some system to keep track of what help options it's already done
21:51:14raptorso i don't see the health help a million times in a row
21:53:04Watusimotoyes
21:53:09Watusimotosee my next checkin
21:53:18Watusimotoevery message shown only once
21:53:32Watusimotoand a serializer to store shown messages in INI
21:53:58Watusimotothe idea being to show every message once forever
21:54:17raptorgood idea!
21:54:29Watusimotobut I'm bogged down in a stupid bug fix
21:58:05raptorblech
21:58:14raptorI consolidated the weird shutdown crashes on the bug list..
21:58:28raptorI bet the issue has nothing to do with any of the stack traces..
22:01:40Watusimotodo they only happen when running weird bobdaduck stuff?
22:02:10raptorno, none of them have to do with bobdaduck
22:02:21raptorall after using the editor
22:02:30raptorfor some amount of time
22:08:05Watusimotohelp me out here a sec
22:08:14Watusimotoif I have a loadout, say 1-2 1-2-3
22:08:18Watusimotoand I die
22:08:29Watusimotoand I respawn (in a level with a loadout zone)
22:08:39Watusimotodo I get default loadout, or 1-2 1-2-3?
22:10:07Watusimotomaybe this bug isn't a bug
22:12:22raptoryou keep you loadout
22:12:56raptorWatusimoto: what bug do you think you have?
22:13:36WatusimotoI do have a bug
22:13:49Watusimotowhen you die and respawn, you get the default loadout, now what you had when you died
22:14:00Watusimotoin 018 you get what you had when you died
22:14:09Watusimotowhich makes more sense anyway
22:14:35raptorweird
22:14:47raptorsoo.. was all the 'const' worth it?
22:14:57Watusimotowell
22:15:01Watusimotomaybe
22:15:19Watusimotowhat do you think about const in this context?
22:15:29raptorseems like it's only used for documentation
22:15:30Watusimotovoid xxx(const string &abc)
22:15:39Watusimotovs void xxx(string &abc)
22:15:44raptornow that *is* an optimization
22:15:47raptorbut
22:15:49Watusimotono
22:15:58raptoroohhh
22:15:59raptorwait
22:16:01raptorok
22:16:03raptorboth are references
22:16:11Watusimotoonly diff is that the 2nd can modify abc
22:16:14raptoryes
22:16:33Watusimotoso is const good in that context?
22:16:33raptorso a safety check
22:17:05Watusimotosafety check and an enforcement on separation of logic
22:17:14Watusimotoso I contend that a render method shoudl not be modifying state
22:17:22raptoryes
22:17:24raptorok
22:17:25Watusimoto(generally)
22:17:39Watusimotoso if you mark that method as const, you will find out if that contention is correct
22:18:05Watusimotoand then you can't accidentally start modifying state on some sub sub sub function
22:18:20Watusimotoso it's a little more than just documentaiton
22:18:23raptorbut
22:18:31Watusimotoit's also setting a rule about how a function should behave, and enforcing it
22:18:33raptoryou put 'const' at the end of the method
22:18:39Watusimotoyes
22:18:46Watusimotovoid soSomething() const;
22:18:47raptorthat doesn't enforce const
22:19:04raptorit just makes it so it *can* be called from a const reference
22:19:10raptor(or so I thought)
22:19:11Watusimotothat means that doSomething() can't modify its this object
22:19:29raptor has to go read on const *again*
22:19:33Watusimototry it
22:19:45Watusimototake a method marked const and try modifying this
22:20:31raptorit's 'this' object
22:20:34raptorits
22:20:46Watusimotoyes
22:20:52Watusimotoso this would not work:
22:21:08WatusimotoClientInfo::xxx() const { this->yyy = 1 }
22:21:13Watusimotothat would not compile
22:21:24Watusimoto(even if it had a ;)
22:24:09raptor"does not modify the non mutable members of its class"
22:24:13raptorok, you win
22:24:16raptor(like usual)
22:24:29Watusimotoso... the factual case seems settled
22:24:35Watusimotobut the question of is it worth it...
22:24:40raptor^^ yes
22:24:41WatusimotoI think so
22:24:42raptor:)
22:24:44raptorok
22:24:53Watusimotobut it is contagious
22:24:57raptormaybe we should rewrite the game in python!
22:24:59Watusimotowhich is why I did all that stuff at once
22:25:09raptorvery virulent
22:25:15Watusimotoconst things can only call other const things
22:25:26Watusimotoin python NOTHINg is const
22:25:38raptorand when 'virtual' is involved...
22:25:39Watusimotomakes debugging so much fun!
22:25:54Watusimotowhen virtual is involved, all overrides have to have same const
22:26:00Watusimotoor they are not overrides
22:26:07Watusimotothey are just bugs
22:26:10raptori wish there was some way that the compiler would warn..
22:26:15Watusimotono kidding
22:26:24raptorbecause, that's an easy way to break everything!
22:26:30Watusimotono kidding
22:26:37Watusimotothat has bitten me a dozen times
22:26:53Watusimotoc0x++-011! has an override keyword that will fix that
22:27:01raptorwait! gcc might have it
22:27:07Watusimotoit might
22:27:26raptorwoudl it be useful to do a compile with it and see if anything is bad?
22:28:17raptor-Woverloaded-virtual
22:28:27raptori'm going to try and see if it yells at me
22:28:31Watusimotook
22:28:50WatusimotoI manually searched for every thing virtual *const
22:29:01Watusimotothen checked all those manually
22:29:03Watusimotowhat a pain
22:29:07WatusimotoI think I got most of them
22:30:33raptorok, getting a few thousand...
22:30:38raptorlet me do just one class...
22:31:08Watusimotowhoa
22:32:24raptorfrom BFoBject: http://pastie.org/pastes/7735123/text
22:33:04Watusimotowhat is this warning about? missing override keywords?
22:33:43thread_ has joined
22:34:12raptorfrom the man page of gcc: http://pastie.org/7735131
22:36:59raptorhi thread_
22:39:46thread_hey
22:41:14Watusimotointeresting... that sort of hiding is confusing to me
22:41:26Watusimotoit seems like f(int) should not hide f)(
22:41:28Watusimotof()
22:41:36Watusimotothey should be able to live side-by-side
22:42:11raptorthey can, but the warning is to possibly catch bugs
22:42:25raptoroh wait
22:42:33raptorone has a parameter.. huh
22:43:33WatusimotoI know that is a problem, but I don't understand why
22:46:04thread_ Quit (Ping timeout: 245 seconds)
22:46:51bobdaduck_m has joined
22:50:44bobdaduck_m Quit (Client Quit)
23:01:05raptorsorry, busy at the moment... if you take a look at if those are actually possible bugs, let me know
23:30:07Watusimotomost of those have to do with the lua proxy... there can't be that many errors that we've never noticed before!
23:31:14raptorback
23:31:17raptorhi
23:31:43raptorthis post has more information about that warning: http://nabble.documentfoundation.org/Woverloaded-virtual-td2725932.html
23:36:51raptorthat first one: Zap::GeomObject::setGeom(const TNL::Vector<Zap::Point>&)
23:37:05raptorvirtual void Zap::BfObject::setGeom(lua_State*, TNL::S32)
23:37:18raptor^^ overloaded by that one - is that OK?
23:43:32kaenbig style changes to http://bitfighter.org/pleiades/ -- let me know what you think
23:43:38kaen(remember to use ctrl+F5)
23:43:43raptoroooo
23:43:56raptorblack as the abyss!
23:44:22kaenas space!
23:45:05raptormaybe add stars for a background? like from the bitfighter homepage
23:45:57raptorhaha 'Airlock deserves your download!'
23:46:41raptoris there a way to just browse maps?
23:46:43kaenwow, the stars help a lot
23:46:50kaensearch lists them all
23:46:54kaenby default
23:46:58raptoroh good
23:47:28kaenand you can click on tags to link to a search which filters on the tag
23:47:42raptoroh neat!
23:47:51raptorI like it!
23:48:45kaenI'm still new at this rounded-corners-gradient-backgrounds thing
23:49:01raptoryeah... don't overdo it too much
23:49:16raptorlike Apple did
23:51:35Watusimoto_ has joined
23:52:34kaenit's overdone the first time you use it, imo
23:52:54kaenbut dark schemes look so terrible if they're flat
23:54:45Watusimoto Quit (Ping timeout: 264 seconds)
23:54:52raptortrue
23:54:56kaenbtw, I switched to a darker them to make room in the color space for the screenshots
23:55:08raptorha! good thinking
23:55:40koda Quit (Quit: koda)

Index Search ←Prev date Next date→

These logs were automatically created by BFLogBot on irc.freenode.net.