Timestamps are in GMT/BST.
| 00:54:28 | | Nothing_Much Quit (Read error: Connection reset by peer) |
| 01:28:36 | | raptor Quit () |
| 03:32:01 | | Akien has joined |
| 04:31:27 | | Watusimoto has joined |
| 04:51:23 | | Watusimoto Quit (Ping timeout: 250 seconds) |
| 07:10:31 | | Darrel Quit (Ping timeout: 244 seconds) |
| 07:10:58 | | Darrel has joined |
| 07:17:33 | | Nothing_Much has joined |
| 09:20:51 | | Darrel Quit (Read error: Connection reset by peer) |
| 09:37:21 | | Darrel has joined |
| 10:16:26 | | raptor has joined |
| 10:16:32 | | ChanServ sets mode +o |
| 11:26:03 | | raptor Quit () |
| 13:39:00 | | Watusimoto has joined |
| 14:10:17 | | kodaone has joined |
| 14:10:18 | | kodaone Quit (Client Quit) |
| 16:10:42 | | raptor has joined |
| 16:10:42 | | ChanServ sets mode +o |
| 16:19:50 | | Watusimoto_ has joined |
| 16:22:51 | | Watusimoto Quit (Ping timeout: 244 seconds) |
| 16:56:54 | | Watusimoto has joined |
| 16:59:32 | | Watusimoto_ Quit (Ping timeout: 244 seconds) |
| 18:32:41 | | Akien Quit (Quit: Quitte) |
| 19:15:36 | raptor | Hello |
| 19:16:24 | raptor | I sort started migrating configuration options, but I noticed something - I could not find how what is in the INI is loaded into the new system |
| 19:16:29 | raptor | *sort of |
| 19:25:41 | | Nothing_Much Quit (Quit: Konversation terminated!) |
| 19:26:27 | Watusimoto | hi |
| 19:26:43 | raptor | hi |
| 19:26:46 | Watusimoto | you mean where the call to read the settings is? |
| 19:27:12 | | Nothing_Much has joined |
| 19:27:13 | raptor | so game starts -> settings defaults loaded -> ini loaded into settings, overwriting defaults |
| 19:27:20 | raptor | i can't find that last one |
| 19:28:35 | Watusimoto | config.cpp >> loadGeneralSettings() |
| 19:28:50 | raptor | I found loadSettingsFromINI, but I have no idea what that loop is doing |
| 19:28:56 | Watusimoto | They very first two lines... "New school" |
| 19:30:00 | raptor | oh wait, i was looking at loadUserSettingsFromINI |
| 19:30:28 | raptor | because that was what was called from main() |
| 19:31:04 | | Watusimoto_ has joined |
| 19:31:35 | raptor | oh.. . i see my confusion |
| 19:31:48 | raptor | there are two settings from different INIs |
| 19:32:01 | raptor | usersettings.ini isn't actually used though? |
| 19:33:30 | Watusimoto_ | I don't think so... I'm not sure where that came from |
| 19:33:40 | | Watusimoto Quit (Ping timeout: 240 seconds) |
| 19:34:09 | Watusimoto_ | oh wait |
| 19:34:27 | Watusimoto_ | I may have created that |
| 19:34:51 | raptor | running hg blame... |
| 19:35:00 | Watusimoto_ | it's used (to the extent that it's used) to track messages the user has already seen |
| 19:35:12 | raptor | yup, you name is all over it |
| 19:35:14 | raptor | *your |
| 19:35:17 | Watusimoto_ | only related to "levelling up" at this point, which is only barely implemented |
| 19:35:52 | Watusimoto_ | the idea being that if two different players are sharing the same machine, we might want to track some things differently for each |
| 19:36:14 | Watusimoto_ | actually, as I write that, we proabably want to track lots of things differently for each |
| 19:36:30 | Watusimoto_ | so usersettings is a place we could do that |
| 19:36:43 | Watusimoto_ | but the concept isnt really developed at this point |
| 19:37:17 | raptor | ah ok |
| 19:38:13 | | Watusimoto has joined |
| 19:38:16 | raptor | ok, so |
| 19:38:27 | raptor | that // New school loop over the 'sections' |
| 19:38:38 | raptor | is there twice |
| 19:38:59 | raptor | once in loadGeneralSettings, but also once before it in the calling method loadSettingsFromINI() |
| 19:39:17 | raptor | we need only once, correct? I don't see a difference... |
| 19:39:23 | Watusimoto | I think so |
| 19:39:25 | Watusimoto | but |
| 19:40:08 | Watusimoto | I haven't looked at this, but we do read the settings once, where default values are filled in for missing/corrupt settings, then we immediatlely write again to get those into the INI |
| 19:40:27 | Watusimoto | we probably don;t need to read again after that |
| 19:40:34 | Watusimoto | so that's probably a bug |
| 19:41:29 | raptor | ok, now i want to just verify the architecture we want |
| 19:41:30 | | Watusimoto_ Quit (Ping timeout: 255 seconds) |
| 19:41:43 | raptor | we'll basically be removing all the load/write methods |
| 19:41:50 | raptor | but keep IniSettings object |
| 19:42:19 | raptor | will we need the IniSettings object after this? |
| 19:45:05 | Watusimoto | I'm not sure... I don;t recall exactly what it does |
| 19:45:19 | Watusimoto | I figured we keep moving stuff and see if there is anything left |
| 19:45:35 | raptor | ha ok |
| 19:46:21 | raptor | so basically the new architecture is to put everything into IniSettings::mSettings |
| 19:48:13 | raptor | and then i guess in game we only reference the GameSettings object |
| 19:48:19 | raptor | which has access to those vi mIniSettings.mSettings |
| 19:48:59 | Watusimoto | when that's done, I want to move mSettings "up a level" so that it's all in mIniSettings |
| 19:49:05 | Watusimoto | (I think that's what I wanted) |
| 19:49:13 | raptor | yes, that's looking like where it's going |
| 19:49:26 | Watusimoto | I basically created mSettings as a holding pen for the new stuff during the transition |
| 19:49:31 | raptor | we'd remove one of those objects somehow |
| 19:49:44 | Watusimoto | after its finished there'll be no need for it |
| 19:58:52 | Watusimoto | I'm trying to figure out how the forums used to look... do you know where the search box was, and where the motd/players playing box was? |
| 19:59:12 | raptor | yes |
| 19:59:44 | raptor | both were in another gray rectangle directly above the main one |
| 19:59:57 | raptor | the one that contains 'User Control Panel' |
| 20:00:13 | raptor | or FAQ |
| 20:00:31 | | raptor Quit () |
| 20:00:41 | Watusimoto | http://i.imgur.com/wApmhvl.png |
| 20:00:45 | Watusimoto | where the arrow is? |
| 20:00:45 | | raptor has joined |
| 20:00:46 | | ChanServ sets mode +o |
| 20:01:10 | raptor | no, above that |
| 20:01:22 | Watusimoto | http://i.imgur.com/sGnSiFG.png ?? |
| 20:01:53 | raptor | yes, a gray box above that |
| 20:01:57 | Watusimoto | ok |
| 20:02:39 | raptor | and the search box... i have no idea, but it wasn't so off as it is now (or was before you moved it) |
| 20:19:24 | Watusimoto | ok, look at the page now |
| 20:19:49 | Watusimoto | should the search bar move left and the current players go to the right, or put current players to teh left? |
| 20:20:33 | Watusimoto | probably search should move left |
| 20:20:47 | Watusimoto | so the box is in a consistent vertical plane with the home page |
| 20:37:47 | raptor | sorry, i was at dinner |
| 20:37:50 | raptor | looking... |
| 20:38:19 | raptor | actually, the search box look pretty good! almost like that was the original place |
| 20:39:20 | Watusimoto | but where would the notice box be, then? |
| 20:39:32 | Watusimoto | I agree... looks better to the right |
| 20:40:19 | raptor | http://www.twiddla.com/1722266 |
| 20:40:58 | raptor | that's where the box was before |
| 20:41:21 | raptor | and it had a gray background or gradient |
| 20:42:01 | Watusimoto | ok |
| 20:42:13 | Watusimoto | I'm going to bed, but I will try that tomorrow |
| 20:42:32 | Watusimoto | working with styles in phpbb is such a pain |
| 20:42:39 | Watusimoto | need to clear cache after each change |
| 20:42:57 | raptor | found it: https://web.archive.org/web/20131217071152/http://bitfighter.org/forums/ |
| 20:43:34 | raptor | it was something i had added since, right between 'Players Online' and 'Board Index' |
| 20:43:49 | raptor | another gray rectangle with green text |
| 20:43:54 | raptor | it had the motd |
| 20:44:07 | raptor | so i guess i was wrong - it was part of the forum div |
| 20:44:17 | Watusimoto | ok search goes down |
| 20:44:21 | raptor | which we may not want to do to keep forum style changes to a minimal |
| 20:44:38 | raptor | also, having a box there might be good sitewide |
| 20:45:16 | Watusimoto | well, that looks more "familliar" |
| 20:45:51 | Watusimoto | good night |
| 20:45:59 | raptor | night! |
| 20:59:22 | | Watusimoto Quit (Ping timeout: 240 seconds) |
| 22:05:23 | | newbee has joined |
| 22:05:47 | | newbee is now known as Guest59799 |
| 22:09:31 | | Guest59799 Quit (Ping timeout: 246 seconds) |
| 23:33:28 | | BFLogBot Commit: 71a9e51673 | Author: buckyballreaction | Message: Some config.cpp clean-up and documentation about migrating settings |
| 23:50:03 | | raptor Quit () |